Submitty
Submitty copied to clipboard
[Feature:Forum] Live Lecture Chat Room
Please check if the PR fulfills these requirements:
- [ ] Tests for the changes have been added/updated (if possible)
- [ ] Documentation has been updated/added if relevant
- [ ] Screenshots are attached to Github PR if visual/UI changes were made
Prototype for #7207
What is the new behavior?
See #7207.
Steps to enable the feature:
In instructor's UI:
go to course settings
scroll down to toggle on live lecture chat:
Now a "Live Lecture Chat" option should be available on the left side menu.
Toggle start session to activate a chat room, then the chat room will be available for the students to join.
Screenshots
Feature includes: Anonymous join - enable/disable in instructor's UI upon creating an editing a chatroom
Notes: The dynamic display of messages is currently through the use of WebSockets.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.65%. Comparing base (
7ffcbb5
) to head (c2afe95
). Report is 213 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10214 +/- ##
=============================================
+ Coverage 22.79% 45.65% +22.86%
=============================================
Files 228 44 -184
Lines 29903 3546 -26357
Branches 75 75
=============================================
- Hits 6817 1619 -5198
+ Misses 23014 1855 -21159
Partials 72 72
Flag | Coverage Δ | |
---|---|---|
autograder | 21.92% <ø> (ø) |
|
js | 27.09% <ø> (ø) |
|
migrator | 100.00% <ø> (ø) |
|
php | ? |
|
python_submitty_utils | 71.65% <ø> (ø) |
|
submitty_daemon_jobs | 91.01% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
I switched to this branch and ran a sumbitty_install as instructor went to sample and have this error preventing me to enter
@RayReyRam I updated the migration and the dump file, can you pull from this branch and try again? If that doesn't work, try (in vagrant ssh) calling migrator -e course rollback
and migrator -e course migrate
to manually apply the migration. If none of this works, try re-creating the sample courses:
sudo bash /usr/local/submitty/GIT_CHECKOUT/Submitty/.setup/bin/recreate_sample_courses.sh --no_submissions
in vagrant ssh.
@williamjallen Is this caused by the removal of the script in the migration file that edits all exiting configs?
@RayReyRam Thanks for the review, I find it really helpful! I added a step in the PR description for how to enable it as a sidebar item. I haven't added the mechanism to disable students to entering messages upon terminating a session, or limiting students' access to the entire chat history just yet. I would like to hear back from the reviewers and decide how to design these mechanisms.
This is on hold of being merged till https://github.com/Submitty/Submitty/issues/10296 is closed
This PR has been inactive (no commits and no review comments) for 12 days. If there is no new activity in the next 48 hours, this PR will be labeled as Abandoned PR - Needs New Owner and either another developer will finish the PR or it will be closed.