UnitTesting icon indicating copy to clipboard operation
UnitTesting copied to clipboard

Drop AutomaticPackageReloader requirements

Open deathaxe opened this issue 2 years ago • 1 comments

Fixes #228

  1. Remove all existing modules from sys.modules[] cache to force them being reloaded in correct order. This strategy is battle proved by A File Icon, GitGutter and PackageDev.
  2. Drop obsolete AutomaticPackageReloader dependencies.
    • Reloading ut.py always reloads all submodules.
    • Recreating UnitTesting33 each time is acceptable.

deathaxe avatar Dec 03 '23 14:12 deathaxe

This is unrelated to #228.

kaste avatar Mar 07 '24 10:03 kaste

It primarily makes those reloaders obsolete.

EDIT: OK, only for relaoding UnitTesting itself. Not for packages being tested.

deathaxe avatar Mar 07 '24 17:03 deathaxe

LGTM but it's lacking a command that initiates the reloading. This is quite important when actually working on a package. That you can reload it quickly and easy. I typically bind such a command to a build system so that it's accessible on ctrl+b.

Nit: You forgot to remove the "Fixes #\228" pragma in the PR description.

kaste avatar Mar 08 '24 09:03 kaste

Maybe we can have a generic reloader command -> https://github.com/kaste/KissReloader

kaste avatar Mar 08 '24 10:03 kaste