Spacegray icon indicating copy to clipboard operation
Spacegray copied to clipboard

Compatibility with sidebar icons

Open maxim opened this issue 10 years ago • 16 comments

With today's release of 3062 the new sidebar icons have been added to ST3. They don't work well with the theme, the spinner goes on forever on start, and folders appear next to arrows.

screen shot 2014-05-05 at 8 34 45 pm

maxim avatar May 06 '14 00:05 maxim

Seeing the exact same thing. Spinner keeps on spinning until you click into the folder.

jasonlewis avatar May 06 '14 00:05 jasonlewis

They are talking about some of this in the forums. I'm sure a pull request or some suggestions would be appreciated.

kimroen avatar May 06 '14 08:05 kimroen

Same thing here...spinners all over the place :S

harris21 avatar May 06 '14 18:05 harris21

+1

chrisspiegl avatar May 07 '14 13:05 chrisspiegl

:+1: needs urgent fix

serkanyersen avatar May 09 '14 00:05 serkanyersen

+1

bstrahija avatar May 14 '14 14:05 bstrahija

Perhaps somebody can help @disusered with #104?

gaearon avatar May 14 '14 17:05 gaearon

Fixed in #105

salttis avatar May 14 '14 17:05 salttis

I would love to keep the files & folder icons & it'll be even better if they match the theme.

ahmedelgabri avatar May 19 '14 13:05 ahmedelgabri

I would love to keep the files & folder icons & it'll be even better if they match the theme.

:+1: :pray:

hkdobrev avatar May 19 '14 13:05 hkdobrev

I would love to keep the files & folder icons & it'll be even better if they match the theme.

:+1:

Morganjackson avatar Jul 18 '14 09:07 Morganjackson

https://github.com/kurtextrem/spacegray/releases/tag/1.3.0-beta.1 :)

kurtextrem avatar Aug 31 '14 05:08 kurtextrem

@kurtextrem Great job! :+1: You just need to update the path here to icons/folder2 instead of Spacegray/folder2

You should open a PR here too to be merged into the main repo

ahmedelgabri avatar Aug 31 '14 06:08 ahmedelgabri

Great catch, overseen that! Thank you. Updated version: https://github.com/kurtextrem/spacegray/releases/tag/1.3.0-beta.2 Pull request is out already. :)

kurtextrem avatar Aug 31 '14 07:08 kurtextrem

Great work @kurtextrem I'll just put my 2 cents feedback here, since you don't have issues on your repo.

  • Remove the sidebar arrows, they don't make sense with folder icons.
  • Remove the tint on the icons, I find it hard on my eyes or maybe decrease it a bit.

ahmedelgabri avatar Aug 31 '14 07:08 ahmedelgabri

Will this PR ever get merged?

duro avatar Nov 18 '14 23:11 duro