PowerShell icon indicating copy to clipboard operation
PowerShell copied to clipboard

Editor-Syntax

Open keith-hall opened this issue 7 years ago • 6 comments

Hi,

I believe that the Editor-Syntax repository has had a few bug fixes upstream since it was copied for use in this repo. Would it make sense to have it as a git submodule, to make it easier to see which version is currently being used by this package, and easier to update this package to use the latest version?

keith-hall avatar Jul 23 '18 11:07 keith-hall

ST package manager currently uses master for install. Can it work with submodules? If so, we should do that.

vors avatar Jul 28 '18 18:07 vors

Good question - Package Control just uses GitHub's zip download feature, so I guess it depends whether submodules are included in the zip or not. I will try to investigate this, thanks.

keith-hall avatar Jul 28 '18 18:07 keith-hall

Thank you, Keith, for taking a look at it. I was too lazy to investigate it properly. If it turns out that it doesn't, we can include a file with a commit sha and a script to auto-update it, something like that.

vors avatar Jul 28 '18 23:07 vors

I have tested, and GitHub doesn't include submodules in the zip file. Your auto update script idea sounds like a good one.

keith-hall avatar Jul 29 '18 06:07 keith-hall

Could you (hard|soft|sym)link to the file that lives in the submodule such that GitHub adds it to the zip? And make a script to convert the file (if Git thinks the link is a file) into a link to be run after clone?

michaelblyons avatar Mar 26 '19 17:03 michaelblyons

Not sure is it possible or not. Currently there is no submodule because I don't know how sublime packages with submodules work.

vors avatar Apr 21 '19 00:04 vors