"Stop"-button feels off

[hannesschulze]

The red "stop" button doesn't really seem to fit into the app

[SubhadeepJasu]

We need a handy stop button. If the placement or design is off, then I could use some suggestions or designs.

[hannesschulze]

Do we really need an extra stop button? I think we could implement this in the main button

[SubhadeepJasu]

We need an universal stop button. The Mycroft enclosures have them. As to answer why, just ask Hemera to read out the news and try to get it to stop reading. The button is supposed to stop Mycroft from speaking anything when necessary. Originally I wanted to make the button completely circular, but the style wasn't getting there.

[SubhadeepJasu]

May be we can move it to header bar, what do you say?

[hannesschulze]

Sure, we need a way to stop Hemera talking. But a much better solution imo might be to have 3 different states for the button

• Inactive, pushing it will make Hemera start listening
• Listening, pushing it will make Hemera stop listening and read the answer
• Speaking, pushing it will make Hemera stop reading the answer

What do you think about this?

[SubhadeepJasu]

The purpose is different. Mycroft stops listening anyway when it doesn't hear anything for a while which is handle by Mycroft. We can definitely make the user push the mic button to stop listening. But we need another "universal stop" button, which stops mycroft from speaking, playing audio, searching, executing a skill, etc, along with stopping mycroft from listening. There is a dedicated message for stopping Mycroft. Hence the button. We can move the button else where but it should be there.

On Sun, May 5, 2019 at 1:19 PM Hannes Schulze [email protected] wrote:

Sure, we need a way to stop Hemera talking. But a much better solution imo might be to have 3 different states for the button

• Inactive, pushing it will make Hemera start listening
• Listening, pushing it will make Hemera stop listening and read the answer
• Speaking, pushing it will make Hemera stop reading the answer

What do you think about this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SubhadeepJasu/hemera/issues/21#issuecomment-489400586, or mute the thread https://github.com/notifications/unsubscribe-auth/AE6U6GNQJHEGA6TCJ6RYGTDPT2GQTANCNFSM4HKZJJJA .

[hannesschulze]

But I think this purpose would be much more useful. We get notified when Mycroft stops listening, right? - why can't we implement this ourselves then? As I said, there are three states - one state makes Mycroft start listening, the other two stop it. Only one of them is running at the same time - so why do we need "another" universal stop button? We can still send the stop-command if we know which state we're currently in.

[SubhadeepJasu]

You are only considering the listening aspect of it. While stop encompasses several other functionalities.

[hannesschulze]

Sure. That's why I'm talking about three states - idle, listening and answering - which is basically every possible state afaik, correct me if I'm wrong..

[SubhadeepJasu]

Right. We have to consider the following types of responses.

• Audio output
• MP3 output

We need to track when it is answering.

[SubhadeepJasu]

There may be some more types but I still don't know.

[SubhadeepJasu]

I'll look into it.