GitHub-Dark icon indicating copy to clipboard operation
GitHub-Dark copied to clipboard

Add more `--color-attention` vars

Open fanninpm opened this issue 2 years ago • 3 comments

This increases some contrast w/r/t some status elements. The effect is more noticeable with text, but I couldn't figure out how to get Firefox to screenshot that.

Before: image

After: image

Screenshots taken from @the-j0k3r's user page.

fanninpm avatar Sep 18 '21 19:09 fanninpm

Mine looks like this

Capture

the-j0k3r avatar Sep 18 '21 21:09 the-j0k3r

Are you sure about that?

image

fanninpm avatar Sep 18 '21 22:09 fanninpm

Very sure, I dont use this style anymore, I use my own in conjunction with the border radii style, I just replied with that because its my profile page you used =). Its always nice to see my mugshot =)

But on topic here lets see. this https://gist.github.com/the-j0k3r/0c00f2d4d6c2b0cf20d6db063df026e1 those css vars are removed from the support domain section of this style.

They should be in main, and these issues wouldn't exists as much.

Those vars need to be removed from the @media prefers and using one of the sets only on main.css.

the-j0k3r avatar Sep 19 '21 10:09 the-j0k3r

Looks okay I guess. For reference, here are the vars that are overwritten with this:

image

silverwind avatar Apr 03 '23 18:04 silverwind

Actually I have to revert, this breaks code highlights which relies on these colors not being semi-transparent:

image

Example: https://github.com/go-gitea/gitea/pull/23901/files#diff-1854903b94080fa2568cfa2701a3f1c7a341767e073204c007af034cbcc50402R58

silverwind avatar Apr 03 '23 19:04 silverwind