GitHub-Dark icon indicating copy to clipboard operation
GitHub-Dark copied to clipboard

Some border issues

Open Geeyun-JY3 opened this issue 4 years ago • 26 comments

  • Browser: Cent Browser 4.3.9.248 (64-bit) (Chromium 86.0.4240.198), Chrome 87.0.4280.141 (Official Build) (64-bit)
  • Operating System: Windows 10 20H2 19042.685
  • Link to page with the issue:
    1. Dashboard: https://github.com/
    2. PR: https://github.com/sindresorhus/refined-github/pull/3837
    3. User's own comment box
  • Screenshot:
    1. Two rounded corners of the Show more button in the dashboard is not sleek. gif Casue its native dark theme looks good: native_dark_theme Maybe a GitHub's native light theme bug: gif1
    2. One of the horizontal rule in mergeability box: image image Edited: Maybe also a GitHub bug
    3. User's own comment box image A little bit difference if zoomed in image

Geeyun-JY3 avatar Jan 10 '21 12:01 Geeyun-JY3

The border of Refined GitHub’s pinned issue list layout also has this bug (enable clean-pinned-issues) gif

Geeyun-JY3 avatar Jan 15 '21 02:01 Geeyun-JY3

iii: if you see the alignment issue when zoomed in its a upstream bug, you dont actually say in which conditions iii is manifested.

you may want to also test with https://github.com/StylishThemes/Feature-Override-Styles/blob/master/github-custom-border-radii.user.css installed

the-j0k3r avatar Jan 15 '21 10:01 the-j0k3r

ii seems got fixed by GHD now…One of the recent versions

Geeyun-JY3 avatar Jan 15 '21 12:01 Geeyun-JY3

Still looks like a border-radius issue that maybe fixed with the style I mentioned.

the-j0k3r avatar Jan 15 '21 14:01 the-j0k3r

Still looks like a border-radius issue that maybe fixed with the style I mentioned.

Tested. Can't fix it.

Geeyun-JY3 avatar Jan 15 '21 14:01 Geeyun-JY3

and have you disabled refined github to see if it its not it causing it?

the-j0k3r avatar Jan 16 '21 08:01 the-j0k3r

and have you disabled refined github to see if it its not it causing it?

Tested. RGH didn't cause it.

Geeyun-JY3 avatar Jan 16 '21 09:01 Geeyun-JY3

Well I can t help you further, I dont use style anymore and as such cant really fix it for you, so you'll have to wait for someone to get to it.

Also I can say with some certainty that some border issues you reported exist upstream, but due to styling colors the issues arent so on your face obvious, though some issues with borders may be caused by this style because it adds many opinionated overrides that cause issues.

You cant however just switch style between on off and not refresh page, cause the local css will still be loaded in memory.

I can recommend you choose in settings background ---> none I bet some of these are caused by it.

the-j0k3r avatar Feb 01 '21 15:02 the-j0k3r

Also for diffs in e.g. pull requests or commits: image

MarcelCoding avatar Mar 13 '21 22:03 MarcelCoding

@MarcelCoding I can recommend you choose in settings background ---> none, these issues are related to backgrounds where there shouldn't be any.

the-j0k3r avatar Mar 14 '21 05:03 the-j0k3r

@the-j0k3r This actually does not fix the bug. In the developer tools I tried to add overflow: hidden (on the element with the border) and it solved the problem. image

MarcelCoding avatar Mar 14 '21 09:03 MarcelCoding

Dashboard: https://github.com/

Is fixed, the others I could not reproduce.

silverwind avatar Mar 16 '21 20:03 silverwind

@silverwind this error still occurs: https://github.com/cryptic-game/java-backend/pull/277/files If you hover over it you will see it much better. image

MarcelCoding avatar Mar 16 '21 20:03 MarcelCoding

Can't see an issue on that expander button besides inaccurate border radius, but that's GH's fault.

image

silverwind avatar Mar 16 '21 20:03 silverwind

Maybe it depends on the browser? I use firefox

MarcelCoding avatar Mar 16 '21 20:03 MarcelCoding

Unlikely. Try with latest version which has some fixes around diffs, otherwise link some more pages with such issues.

silverwind avatar Mar 16 '21 21:03 silverwind

I've just updated the theme. Tomorrow I will post some more issues.

MarcelCoding avatar Mar 16 '21 21:03 MarcelCoding

As I already said part of the issue is the image backgrounds, you cant have any selected.

the-j0k3r avatar Mar 17 '21 07:03 the-j0k3r

image https://github.com/spring-projects-experimental/spring-native/commit/863b80cd2b1fbcc137d5c70c72c8e92c03c79e0c

No matter what background I select, the background is always overlapping.

MarcelCoding avatar Mar 17 '21 12:03 MarcelCoding

No matter what background I select, the background is always overlapping.

It must be set to none.

Capture

the-j0k3r avatar Mar 17 '21 14:03 the-j0k3r

I don't know what I am doing wrong. I am gonna keep it as it is. I tried every background including none. Thank you for your help.

MarcelCoding avatar Mar 17 '21 14:03 MarcelCoding

Those green backgrounds look fine again to me. It's hard to see what is actually wrong in your screenshot. Can you zoom in the page?

silverwind avatar Mar 18 '21 18:03 silverwind

@silverwind If you open the link and hover over it you can clearly see that the blue background is overlapping. Unfortunately I can't take screenshots while I am hovering over the element.

MarcelCoding avatar Mar 18 '21 19:03 MarcelCoding

image

MarcelCoding avatar Mar 18 '21 19:03 MarcelCoding

Looks fine to me even when hovering. Try reinstalling the style.

image

silverwind avatar Mar 18 '21 21:03 silverwind

That also don't solve the problem. I will accept it as it is.

MarcelCoding avatar Mar 19 '21 10:03 MarcelCoding