File background doesn't use theme background

[ofsaleem]

• Browser: Vivaldi 2.9.1705.41
• Operating System: OSX Mojave
• Link to page with the issue: (any file, but for example https://github.com/StylishThemes/GitHub-Dark/blob/master/github-dark.css)
• Screenshot:

Using Solarized Dark theme. contrast with what it looks like in snippets:

[ofsaleem]

I should also add this broke after a recent update. I'm not sure what version to what version of the style broke it though; I have to make an edit to add my company's internal github domain to the style so I have to manually update whenever I remember to do that.

[the-j0k3r]

I should also add this broke after a recent update

this is the .highlight selector, which doesnt exist in the GitHub themes.

I can add it, but the diff-colors are not theme specific atm, and I dont have time to mess around with the themes to properly do it.

If not adding e.g solarized `.highlight {background: #002b36 !important; } would end up with something ugly.

its not just solarized, and no this has not worked in any GitHub themes. They all missing the selector. probably because it interferes with something else on style.

[the-j0k3r]

Actually much works needs to be done to support this properly, were missing, highlight, the line hover colors/ diff colors and probably something else I missed to make this work properly.

This is in ALL GitHub themes, https://github.com/StylishThemes/GitHub-Dark/tree/master/themes/github not a simple task, this is why this wanst added already.

Sadly I dont have time for this much work in one go or maybe even 20 go's, so adding just highlight is not something I would do on it own.

It will have to wait, many I need more hands and another 20 hours a day, so 44 hours in day I may be able to do all. =)

[xt0rted]

I was able to get this to work by changing the following:

--- a/github-dark.css
+++ b/github-dark.css
@@ -9577,7 +9577,11 @@
   .flash p code {
     background-color: inherit !important;
   }
-  .blob-code, .blob-code-inner {
+  table.highlight .blob-code {
+    background-color: var(--ghd-code-background, #141414) !important;
+    color: var(--ghd-code-color, #ccc) !important;
+  }
+   .blob-code-inner {
     color: var(--ghd-code-color, #ccc) !important;
   }
 }

I'm not sure if it breaks anything else though so I don't want to commit it without some more testing.

[ofsaleem]

that's super weird that i used to have it then. maybe i got a fix from somewhere else and it got overwritten at some point... i know it's ugly but it's functional to have the diffs look like that still, and it's way more important to me to have the green background everywhere than it is to have a theme specific diff. i'll look in to fixing it again, thanks you two

[ofsaleem]

i went with .highlight {background: #002b36 !important; } because xt0rted's method doesn't change the background for the blame page (which looks kinda weird, but is at least green). this works for my personal preference, tyvm

[xt0rted]

When I was looking around the site, before my change, the only spot I saw that wasn't styled correctly was when viewing a file. Diffs were using the syntax theme background color.

• Styled correctly: https://github.com/StylishThemes/GitHub-Dark/commit/a2547cefecfbf99c88a5b053a6bf61599b82a64d
• Styled correctly but wrong background color: https://github.com/StylishThemes/GitHub-Dark/blob/master/package.json

Is that what you're seeing too? Are there any color differences when viewing code on github.com vs. your github enterprise instance?