eslint-plugin-header icon indicating copy to clipboard operation
eslint-plugin-header copied to clipboard

Preserving new lines at the end of the template file (fixes #37)

Open liarco opened this issue 3 years ago • 5 comments

This PR fixes #37.

Implementation details:

  • the comment parser now returns a third array value with the number of new lines at the end of the given comment
  • the initialization function runs the parser before setting the new lines count and EOL format in order to base its decisions on the template file content (if available)
  • tests have been updated to support the new parser feature and check that both UNIX and Windows EOLs work properly

I hope that this can be useful, please feel free to ask for changes or any further information.

Thank you for your time.

liarco avatar Sep 24 '21 08:09 liarco

Hi @Stuk, I'm tagging you just to check if this project is still active or not.

Thank you for your time.

liarco avatar Sep 30 '21 21:09 liarco

Hi @Stuk, I'm sorry to bother you, but do you have any news about this?

liarco avatar Oct 18 '21 17:10 liarco

@Stuk This is really useful feature

max-kuzmin avatar Nov 02 '21 09:11 max-kuzmin

Thank you @MaxGsomGsom, unfortunately I'm not receiving any feedback from @Stuk. Maybe he's busy or doesn't have the notifications enabled.

liarco avatar Nov 02 '21 09:11 liarco

Cool feature! Thanks, @liarco

annkupriyanova avatar Nov 03 '21 10:11 annkupriyanova