elFinder icon indicating copy to clipboard operation
elFinder copied to clipboard

Folder upload does not work

Open VitalyEmelyanov opened this issue 4 years ago • 8 comments

We are using the elFinder with rails backend and api v1.

After updating the version to 2.1.51, the folder upload stopped working (same issue on the latest version 2.1.57)

Before, at version 2.1.21 it worked fine.

The folder is picked via the button "Select folder". After this the directory is created, however the files are not uploaded

Current behavior (2.1.51):

  1. The mkdir request is sent
cmd: mkdir
target: Lg
dirs[]: 
dirs[]: /test
current: Lg
  1. The open request is sent
cmd: open
reload: 1
target: Lg
tree: 1
compare: 

Expected behavior (2.1.21):

  1. The mkdir request is sent
cmd: mkdir
target: Lg
dirs[]: test
current: Lg
  1. Files are uploaded
cmd: upload
current: Lg
upload[]: (binary)
mtime[]: 1575280501
upload_path[]: test

VitalyEmelyanov avatar May 06 '21 15:05 VitalyEmelyanov

+1 - same here. Any suggestions welcome

guitarzero avatar May 10 '21 16:05 guitarzero

+1 , also see this, how can we fix this issue?

dup2 avatar May 19 '21 09:05 dup2

+1, I also faced with this issue. Please, help!

ujinius avatar Jun 02 '21 09:06 ujinius

What is the protocol version?

210611-142814

nao-pon avatar Jun 11 '21 05:06 nao-pon

What is the protocol version?

210611-142814

Version: 2.1.51 protocol version: 1 jQuery/jQuery UI: 3.5.1/1.12.1

VitalyEmelyanov avatar Jun 11 '21 10:06 VitalyEmelyanov

@VitalyEmelyanov "protocol version: 1" shouldn't support folder uploads, but since it was possible in 2.1.21, is it partially supported?

The first post suggests that there is a problem with the mkdir parameter target hash prefixed with "/".

When you select a folder from the upload dialog and upload it, "/" is added at the beginning, so DnD was unified to that.

Please ask the developer of the rails backend connector.

nao-pon avatar Jun 11 '21 12:06 nao-pon

further, Since the open command is sent after the mkdir command, it indicates that an error occurred in the connector response of the mkdir command.

nao-pon avatar Jun 11 '21 12:06 nao-pon

@nao-pon, I'm also experiencing the same issue in 2.1.60 when I drag-drop a folder myDir which contains one file myFile.png.

Actual: Only myDir is created but myFile.png is not uploaded. Expected: myDir is created and myFile.png is uploaded under myDir.

With my backend remain unchanged, I tried versions of ElFinder JS and manage to identify that https://github.com/Studio-42/elFinder/releases/tag/2.1.42 is the last version where it works as expected, and issue starts to happen beginning https://github.com/Studio-42/elFinder/releases/tag/2.1.43.

See my testing:

2.1.42

cmd: ls
target: 33747361-e30e-47cc-8817-78c2598042d9_Lw
intersect[]: myDir
reqid: 17e7b245cb2298
cmd: mkdir
target: 33747361-e30e-47cc-8817-78c2598042d9_Lw
dirs[]: /myDir
reqid: 17e7b245cd31df
reqid: 17e7b245ce63ab
cmd: upload
target: 33747361-e30e-47cc-8817-78c2598042d9_Lw
upload[]: (binary)
mtime[]: 1633694385
upload_path[]: /myDir/myFile.png
dropWith: 0

2.1.43 and 2.1.60

cmd: ls
target: 33747361-e30e-47cc-8817-78c2598042d9_Lw
intersect[]: myDir
reqid: 17e7b262dcf2ca
cmd: mkdir
target: 33747361-e30e-47cc-8817-78c2598042d9_Lw
dirs[]: /myDir
reqid: 17e7b262de335c

It seems to be missing the upload call. Hope these new info above can help isolate the cause.

kenston avatar Jan 21 '22 05:01 kenston

This issue is stale because it has been open for 50 days with no activity.

github-actions[bot] avatar Aug 11 '23 02:08 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Aug 25 '23 02:08 github-actions[bot]