FreeCAD-Gridfinity-Workbench icon indicating copy to clipboard operation
FreeCAD-Gridfinity-Workbench copied to clipboard

stacking lip not included in height total

Open kinghat opened this issue 10 months ago • 6 comments

i can sort of see why its not included in the total height when using height units but when using a custom height i think it should. usually the person is setting a specific height that the bin has to be.

Image

also is it intentional to model the bin in the -Z from the origin vs above?

kinghat avatar Feb 09 '25 03:02 kinghat

I see how that could be confusing for a user but at the same time I don't really see the stacking lip as part of the bin. If you were to stack another bin you would not be able to use that height.

easy changes would be: adding to the tooltip when hovering that it doesn't include the label shelf. Or potentially a second reference dimension that does include it.

I would be open to changing this if there was a really good proposed alternative. However, this would not be an easy change as this parameter is heavily used throughout both bin and baseplate generation code (but only bin would change) and I would want to have a super solid alternative before undertaking that.

Stu142 avatar Feb 09 '25 16:02 Stu142

Or potentially a second reference dimension that does include it.

I think it would be useful to give the total height, width and depth of the bin. It would serve as a "sanity check" for the user. (You can get that information from the slicer, but it would be nice to have it in FreeCAD before generating the STL.)

hkienle avatar Feb 10 '25 08:02 hkienle

is it intentional to model the bin in the -Z from the origin vs above?

I guess this is most useful for blank (i.e. "filled") bins. This allows you to take away material starting from z=0 and going in the negative direction.

hkienle avatar Feb 10 '25 08:02 hkienle

I think the field we should be talking about is "Reference Parameters > Total Height", not "Gridfinity Non Standard > Custom Height". @Stu142 I think this field shouldn't affect generation?

I see the Total parameters in the Reference section as ones you would measure with a vernier caliper. Note that seeing clearance subtracted from Total Width, it would be reasonable to assume that stacking lip is included in Total Height – which is not the case.

Image

When this will be correctly calculated, it will be easy to create a bin with a given total height – just create a bin and add whatever is the difference you are missing to Custom Height.

greg19 avatar Feb 10 '25 10:02 greg19

The consensus is clear then and I agree it does make intuitive sense that 'Total Height' actually means the total.

@greg19 the reference parameters started as parameters I created for use in generating features then I thought they could be useful to the user so I made them visable as a result they are all quite heavily used throughout feature generation.

Edit: I might have misread. The reference parameters are read only and calculated from other properties but the values are used for generating features.

Stu142 avatar Feb 10 '25 13:02 Stu142

I suppose I could just do a find and replace for most of them so it shouldn't be too bad.

Baseplates have 'TotalHeight' as well so I would have to make sure the change doesn't interfere.

Stu142 avatar Feb 10 '25 13:02 Stu142