kolasu

kolasu copied to clipboard

See https://github.com/Strumenta/kolasu/blob/ee6bab757be1389c2f31835bbecfcd128c09b50f/lionweb/src/main/kotlin/com/strumenta/kolasu/lionweb/StarLasuLWLanguage.kt#L262 We could introduce some sort of encoding, minimize the representation of ranges. Binary is also always an option. Suggested by @martin-azpillaga

ftomassetti

We repeat over and over code such as: ``` val cleanName = name!!.replace('.', '_').replace(' ', '_').replace("@", "_at_") .replace("#","-").removeCharactersInvalidInLionWebIDs() ``` All this logic could be inserted in a function, perhaps expanding...

ftomassetti

See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_semanticTokens ``` namespace = 'namespace', type = 'type', class = 'class', enum = 'enum', interface = 'interface', struct = 'struct', typeParameter = 'typeParameter', parameter = 'parameter', variable = 'variable',...

ftomassetti

Comments should be returned as part of the Parsing Result.

ftomassetti

LIonWeb minor code improvements

1

First batch of code improvements

psuzzi

I took a look at the com.strumenta.kolasu.lionweb, and found a few improvements I suggest to implement: - Use of `when` statements instead of nested `if-else` ones, e.g. in JSONComparison -...

psuzzi

Improved the readme by adding prerequisites and build + test instructions fixes #375

psuzzi

Improve the readme by adding prerequisites, and explaining how to build and test

psuzzi

I'll open a PR with a test case. The issue is this: calling withChild with a property that (mistakenly) has no setter causes `childrenSetAtConstruction` to be true, however, if the...

alessiostalla

ftomassetti