antlr-kotlin icon indicating copy to clipboard operation
antlr-kotlin copied to clipboard

Restore pre-1.0.0 behavior for codepoint funs and ObjectEqualityComparator

Open lppedd opened this issue 1 year ago • 1 comments

After making ObjectEqualityComparator an object, I have noticed the outputted code (and the code that's actually invoked) changed.

See the diff. Left 1.0.0-RC4 / Right 1.0.0

image

So in 1.0.0 a call to ObjectEqualityComparator.equals goes through:

f2s(a, b)
  y30(a, b)
   equals(a, b)

Compared to just

f2s(a, b)
  equals(a, b)

In RC4. There is also that weird:

var tmp = (a == null ? true : !(a == null)) ? a : THROW_CCE();

which I don't understand. Why would a ClassCastException be thrown there?
So I thought that it's better to revert it.

lppedd avatar Sep 07 '24 10:09 lppedd

This closes #198.

lppedd avatar Sep 07 '24 10:09 lppedd

You might have to manually restart the workflow.

lppedd avatar Sep 17 '24 15:09 lppedd

Thank you @lppedd jobs restarted. If they pass I will merge

ftomassetti avatar Sep 19 '24 14:09 ftomassetti

@ftomassetti thanks. Would it be ok to release a 1.0.1?

lppedd avatar Sep 20 '24 07:09 lppedd

@lppedd I just released 1.0.1

ftomassetti avatar Sep 20 '24 15:09 ftomassetti