MPSServer icon indicating copy to clipboard operation
MPSServer copied to clipboard

Should not break editor undo

Open ftomassetti opened this issue 4 years ago • 6 comments

Ensure we modify models from command sections in EDT

ftomassetti avatar Jun 23 '20 14:06 ftomassetti

Operations that we do not want to undo will be performed in write actions. For example, saving & reloading Screenshot 2020-06-25 at 09 04 36

ftomassetti avatar Jun 25 '20 07:06 ftomassetti

For all the rest we use execute command in EDT Screenshot 2020-06-25 at 09 07 27

ftomassetti avatar Jun 25 '20 07:06 ftomassetti

For reading, we will ensure it is done in EDT: Screenshot 2020-06-25 at 09 16 57

ftomassetti avatar Jun 25 '20 07:06 ftomassetti

Scratch the last point: we can use read access from outside EDT

ftomassetti avatar Jun 25 '20 07:06 ftomassetti

These changes are now in master. Let's see if they solve the usage of the editor undo. Also, @sergej-koscejev do you have steps to reproduce this?

ftomassetti avatar Jun 25 '20 07:06 ftomassetti

I do, but only using the client project

sergej-koscejev avatar Jun 25 '20 07:06 sergej-koscejev