strider icon indicating copy to clipboard operation
strider copied to clipboard

Use one templating library

Open knownasilya opened this issue 10 years ago • 5 comments

Currently we have swig (outdated/deprecated) and jade. We should pick a templating library and work with that.

Currently jade is used in the emails. Possibly also in plugins. Swig is used everywhere else (server side rendered templates).

  • [ ] Phase1 - Remove jade, use swig for now
  • [ ] Phase2 - Replace or update swig

knownasilya avatar Jan 13 '15 14:01 knownasilya

Definitely get rid of jade. I am not sure why it is still used anywhere - we must've had a couple of places which weren't converted.

Swig is good but does need updating. It has changed a fair amount in the latest version.

On Tuesday, January 13, 2015, Ilya Radchenko [email protected] wrote:

Currently we have swig (outdated/deprecated) and jade. We should pick a templating library and work with that.

Currently jade is used in the emails. Possibly also in plugins. Swig is used everywhere else (server side rendered templates).

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/689.

Niall O'Higgins W: http://niallohiggins.com E: [email protected] T: @niallohiggins

niallo avatar Jan 13 '15 15:01 niallo

yup. I think jade is only used in the emails. we can nix it

jaredly avatar Jan 13 '15 16:01 jaredly

Think it may have been me who added them as part of the email templates. Not sure if they were there already before I modularised them.

Curious as to what your issues with Jade are though? Best templating system I have used in node!

On 13 Jan 2015, at 16:01, Jared Forsyth [email protected] wrote:

yup. I think jade is only used in the emails. we can nix it

— Reply to this email directly or view it on GitHub.

microadam avatar Jan 13 '15 18:01 microadam

Not so much an issue with jade, just an extra dependency and learning curve, since we are using swig extensively.

knownasilya avatar Jan 13 '15 18:01 knownasilya

Figured as much. Best to keep things consistent!

On 13 Jan 2015, at 18:32, Ilya Radchenko [email protected] wrote:

Not so much an issue with jade, just an extra dependency and learning curve, since we are using swig extensively.

— Reply to this email directly or view it on GitHub.

microadam avatar Jan 13 '15 18:01 microadam