strider icon indicating copy to clipboard operation
strider copied to clipboard

jobs should have numbers

Open jaredly opened this issue 11 years ago • 9 comments

I know that many companies like to be able the mark the "build number" that a bug was fixed in. And it wouldn't be hard to implement.

jaredly avatar Oct 19 '13 23:10 jaredly

Yeah, good point. Easy to add a serial key in mongo with $inc.

niallo avatar Oct 20 '13 06:10 niallo

Let's add this in 1.5 with the other Schema changes.

peterbraden avatar Oct 24 '13 00:10 peterbraden

@jaredly these are in right?

knownasilya avatar Aug 12 '14 02:08 knownasilya

not as far as I know. We still just track jobs by mongo id.

jaredly avatar Aug 12 '14 02:08 jaredly

@jaredly why can't the id's just be mongo ids? Aren't those unique?

knownasilya avatar Dec 29 '14 18:12 knownasilya

they're unique but not very parse-able by humans compared with sequences.

I'm not sure what the original issue was about tbh

On Monday, December 29, 2014, Ilya Radchenko [email protected] wrote:

@jaredly https://github.com/jaredly why can't the id's just be mongo ids? Aren't those unique?

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/219#issuecomment-68285779.

Niall O'Higgins W: http://niallohiggins.com E: [email protected] T: @niallohiggins

niallo avatar Dec 29 '14 19:12 niallo

ok, so build 1, 2, 3, etc..

knownasilya avatar Dec 29 '14 19:12 knownasilya

yeah that was the idea

On Mon Dec 29 2014 at 2:28:49 PM Ilya Radchenko [email protected] wrote:

ok, so build 1, 2, 3, etc..

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/219#issuecomment-68293396.

jaredly avatar Dec 31 '14 04:12 jaredly

It would be possible to synthesize build numbers of that kind using the mongoid (since its monotonically increasing) or build time stamp. You'll need to fetch all job objects though I think.

On Tuesday, December 30, 2014, Jared Forsyth [email protected] wrote:

yeah that was the idea

On Mon Dec 29 2014 at 2:28:49 PM Ilya Radchenko <[email protected] javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

ok, so build 1, 2, 3, etc..

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/219#issuecomment-68293396.

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider/issues/219#issuecomment-68423526.

Niall O'Higgins W: http://niallohiggins.com E: [email protected] T: @niallohiggins

niallo avatar Dec 31 '14 14:12 niallo