stride
stride copied to clipboard
Lack of check exist of acctAddress in mint module
Background
SetupNewModuleAccount function doesn't have a check if the acctAddress is exist
https://github.com/Stride-Labs/stride/blob/94e3a91dc582218a477771d9a694966bf901fdf5/x/mint/keeper/keeper.go#L233-L242
so in some cases, we can face some problems with this, I have run simulation for this and face it
Suggested Design
- Add a check if the
acctAddressis exist
Acceptance Criteria
- Check for existing of
acctAddresswas added - All test pass
Can you elaborate on
so in some cases, we can face some problems with this, I have run simulation for this and face it
I don't understand what will break in this case?
Also, if you are running simulation tests, could you share your code for that? We'd like to start using them.
Sure @riley-stride, I coding simulation test for Strid, and will update information of fail soon in the pr of this issue