stride icon indicating copy to clipboard operation
stride copied to clipboard

Refactor msg_server_submit_txs.go

Open sampocs opened this issue 3 years ago • 1 comments

Background

There's room for improvement to make msg_server_submit_txs.go more readable.

Suggested Design

  • Rename file to submit_ica_txs
  • Remove SubmitTxByDayEpoch and SubmitTxByStrideEpoch
  • Create IcaTx struct
  • Separate building of IcaTx struct from function that calls the Ica (and add test coverage that evaluates the individual ica messages)

sampocs avatar Dec 05 '22 21:12 sampocs

OMG I'm writing tests for this function, any logic will be changed ser?

ThanhNhann avatar Dec 07 '22 08:12 ThanhNhann