admins.go is changed during the docker build or test process?

[faddat]

I set off the detector like this:

git fetch --all
git checkout origin/main
git switch -c mundane-items

then I did some work including running:

go test ./...
make build-docker

if this does change admin.go, it shouldn't.

[faddat]

Hey, I am trying to recreate this.

https://github.com/Stride-Labs/stride/blob/main/scripts/upgrades/Dockerfile.cosmovisor

Seems that, leads to this:

https://github.com/Stride-Labs/stride/commit/c74374af476874037d09324d7699e02c6e60d98e

It's too scary, we should fix it.

[sampocs]

When running make build-docker, the admin address gets swapped temporarily and then swapped back after the build. I have noticed a case once where I canceled the build prematurely and it didn't get reverted back, but I was never able to recreate it.

However, build-docker and scripts/upgrades/Dockerfile.cosmovisor are only for running a local docker network though. If you tried to run a node with the incorrect address, you'd get a consensus error. We also have a check in our CI to make sure the address never gets changed on the main branch (in the event of an accidental push)