BetterDiscordStuff icon indicating copy to clipboard operation
BetterDiscordStuff copied to clipboard

ShowAllActivities cant be constructed on newest updates

Open Masono03 opened this issue 1 year ago • 8 comments

As many other plugins now died on the new updates of discord. Cant be constructed.

Canary 139699 (bdc9502) BetterDiscord 1.5.3-Hotfix2 Host 1.0.48 Windows 10 64-Bit (10.0.19044)

Masono03 avatar Aug 03 '22 11:08 Masono03

Same here image

patrickzhou1234 avatar Aug 03 '22 19:08 patrickzhou1234

same here:

ShowAllActivities: Could not be constructed.
    at Object.initializeAddon (<anonymous>:4:306851)
    at Object.loadAddon (<anonymous>:4:268341)
    at Object.loadAddon (<anonymous>:4:305889)
    at Object.reloadAddon (<anonymous>:4:269050)
    at FSWatcher.<anonymous> (<anonymous>:4:266224)

BlueStarBRS avatar Aug 03 '22 20:08 BlueStarBRS

@Masono03 @BlueStarBRS Replace it with this one I updated it myself: https://gist.github.com/Kalaborative/32c85b4a79144ea895e9c4ae79c7a987

Works fine for me now.

Kalaborative avatar Aug 06 '22 00:08 Kalaborative

@Kalaborative pelase provide a diff. Saying "use this one I did myself" is a bit suspiscious. If you fixed it why not do a pull request?

Technetium1 avatar Aug 06 '22 17:08 Technetium1

@Kalaborative pelase provide a diff. Saying "use this one I did myself" is a bit suspiscious. If you fixed it why not do a pull request?

Had a check through their code and they've only changed two lines, 158 and 166 with the following...

158 return ___createMemoize___(this, 'Text', () => BdApi.findModuleByDisplayName('LegacyText')) 166 return ___createMemoize___(this, 'Dispatcher', () => BdApi.findModuleByProps('dispatch', 'isDispatching'))

Still this should be a pull request, not a "hey I fixed it use this lol"

Considering all the other plugins look to be using these lines too, most can be fixed by changing these two.

Reagy avatar Aug 07 '22 16:08 Reagy

My apologies if you interpreted that way. It was a minimal workaround which is why I opted for this option rather than a PR.

Kalaborative avatar Aug 07 '22 21:08 Kalaborative

@Masono03 @BlueStarBRS Replace it with this one I updated it myself: https://gist.github.com/Kalaborative/32c85b4a79144ea895e9c4ae79c7a987

Works fine for me now.

thank you very very mush <3

BlueStarBRS avatar Aug 09 '22 18:08 BlueStarBRS

is there a way that again some auto patcher can fix some problems like the last big big base update ? bacuase one of my favorite plugins 8channelDms) is still brocken :/ image

BlueStarBRS avatar Aug 09 '22 18:08 BlueStarBRS

Fixed. Redownload from GitHub

domi-btnr avatar Aug 15 '22 02:08 domi-btnr