stremio-translations
stremio-translations copied to clipboard
Stremio
Update and rename ca-CA.json to ca-ES.json
The language code is not correct. The current one (ca-CA) would be for Catalan spoken in Canada (I wish!), but Catalan is mostly spoken in Spain (along with Andorra, France, and Italy). A correct language code would be ca-ES (although the best practice would be a generic language code "ca.json").
Also, I corrected some typos and untranslated sentences.
Hi @Ecron, thanks for your contribution!
I just wanted to mention this PR that already addresses the untranslated strings, and this opened issue that is related to the language code.
I suggest waiting until the first PR is merged (soon hopefully), and then synchronizing yours with the other string translations + file rename.
Damn it, I didn't see those, my apologies! You should totally wait until those are merged/solved. Sorry again for not checking first 😣
the issue here is that if you change a file name, all the users that ever selected "Catalan" will revert back to english (because the previous translation file / choice would no longer exist)
Is it possible redirect this language to the other in the code for this specific case? Not the best solution but it will work. Or maybe keeping both files (or maybe removing the country extension?).
Nevertheless, we can merge #695 first, clean this PR, and then decide what to do.
Any news on this PR? I see #695 was closed on March 10, #667 was closed on October 14 2023 and there are no changes in #696...
Thanks in advance.
The previous ones were merged (but there's a new one opened 3 weeks ago pending to be merged, not managed by me). I'm not sure what changes are still valid from this PR. Can you synchronize it with the latest changes to see the differences and put it easy to the maintainers?
I just merged the changes I made for this #699 with the changes made by #805, so #805 can be closed and this can be merged.
there is really no good way to go about changing the translation filename, it will break translations for everyone that selected it before
regarding this suggestion:
Is it possible redirect this language to the other in the code for this specific case?
while possible, we don't add hacks to our code under any circumstance..
Ok! Then we have to keep the current filename. @Ecron can you keep the original file name?
The original file name is just wrong. There's no such ISO code as 'ca-CA'. Catalan is not spoken in Canada. The right thing is changing the filename either to 'ca-ES' or to simply 'ca'. I won't keep the original name, I bet users won't mind going to Settings > Languages and set Catalan again if their interfaces fall back to English due to this fix.
The original commit that introduced this file was meant to be for the Catalan language: https://github.com/Stremio/stremio-translations/commit/54a21c9abff0e259998b9bb576385b54f6b0e71f
Whether or not it was meant to be for Canada is a different discussion. The commit is from 3 years ago, changing this would revert to english for (probably) millions of users.
Why not create a separate file for ca-ES without removing this file?
So, if you create a separate ca-ES file, there would be 2 different Catalan entries in the Language settings. Would users even notice that there's a new, updated, improved Catalan translation? Would they have to change it manually in settings in order to display the updated translation? There would be a "legacy", outdated, "Catalan (Canada)" translation, and a new updated "Catalan (Spain)" one, but users would not notice this, so they won't change the language to the correct one.
Or are you suggesting updating the ca-CA with this commit and also creating a new ca-ES file with the same information? This way, there would be also 2 entries in the languages list for Catalan, both with the same info, and you could let ca-CA slowly die by only updating the ca-ES file. But this won't solve your problem, which is that users won't be noticed that they have to change manually from ca-CA to ca-ES. How would you manage that?
Doesn't Stremio app set its language based on the users' system language? Because if this would be the case, deleting the ca-CA file and adding the ca-ES file would make the app match the correct ISO code from the users' system (which is either "ca" or "ca-ES", never "ca-CA"). It would auto-select the correct language for all those users that were using the ca-CA file, or have their system set in Catalan.
I believe that the correct way to handle this is to change the name of the "ca-CA" file to "ca-ES", other ways around it is just patching the issue badly. This solution may make the app fall back to English for those users that were using the app in Catalan, in case the app doesn't set the language automatically based on the system's language. Do you think that all those users won't go to Settings to set again the app in their language? I would.
Either way, I want this to be resolved ASAP because my main goal was to contribute to this great app by fixing the Catalan translation. Please tell me the correct way to handle this, either creating a new ca-ES file or whatever, and I will modify the PR accordingly. Apologies for this long discussion.
I agree that we should solve this soon to unblock the translation of the newer strings. I understand the pros&cons so I don't have any strong opinion. I'll agree with your decision (knowing that it seems impossible to include a "migration step" embedded in the code).