stremio-translations icon indicating copy to clipboard operation
stremio-translations copied to clipboard

Same string keys multiple times

Open cosmoscalibur opened this issue 6 years ago • 5 comments

I see that many string keys string keys are multiple times in Caps, nocaps and ALLCAPS forms when string translation is the same. Is that necessary?
Because maintenance is more easy if the same translation string is only in one string key, use only one version could be a good option.

cosmoscalibur avatar Jan 10 '18 16:01 cosmoscalibur

where is that? could be by mistake

Ivshti avatar Jan 17 '18 14:01 Ivshti

For example in en-US.json. Some repeated translation strings are:

"TYPE_series": "Series",
"TYPE_series_PL": "Series",
"WEBSITE_TYPE_series_PL": "Series",
"INTRO_TASTE_COMEDY": "Comedy",
"Comedy": "Comedy",
"COMEDY": "Comedy",
"INTRO_TASTE_MUSIC": "Music",
"Music": "Music",
"MUSIC" : "Music",
"ADDONS": "Add-ons",
"WEBSITE_ADD_ONS": "Add-ons",
"INTRO_TASTE_HELP_US": "Help us learn more about you.",
"HELP_LEARN_MORE": "Help us learn more about you.",
"WEBSITE_CREATE_AN_ADDON": "Create an add-on",
"WEBSITE_ADDONS_CREATE": "Create an add-on",

And because this is the template for all you can see in more files.

cosmoscalibur avatar Jan 17 '18 15:01 cosmoscalibur

Hi @Ivshti , also FAQ13 and FAQ18 are the same.

cosmoscalibur avatar Jun 30 '18 03:06 cosmoscalibur

"WEBSITE_LINK_ADDON_SDK" is a duplicate object key.

cosmoscalibur avatar Jun 30 '18 03:06 cosmoscalibur

Hi @Ivshti

I would like to work in this issue, how will be the correct way?.

I think that with these one that have the same key I can just delete one and put the other in uppercase, but what about with those one that have diferentts key?

Same key, same value:

"Music": "Music",
"MUSIC" : "Music",

Result:

~~"Music": "Music",~~

"MUSIC" : "Music",

Diferentt key, but same value:

"WEBSITE_CREATE_AN_ADDON": "Create an add-on",
"WEBSITE_ADDONS_CREATE": "Create an add-on",

Result: ?

What should I do in the last case?

Thanks

robertlluberes avatar Aug 31 '18 21:08 robertlluberes