stremio-addon-sdk icon indicating copy to clipboard operation
stremio-addon-sdk copied to clipboard

Manifest.config.key conflicts with reserved keyword "key".

Open megadrive opened this issue 1 year ago • 3 comments

Using "key" as an object key can lead to issues as it's a reserved keyword. TypeScript threw this up for me as an error. Rather than "key", another word should be used.

The reference in docs: https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/manifest.md#config-format

megadrive avatar Feb 27 '24 09:02 megadrive

i propose length

jaruba avatar Feb 27 '24 10:02 jaruba

I'm assuming you're joking, but why not id?

megadrive avatar Feb 27 '24 10:02 megadrive

the addon configuration properties do no impact the addon sdk in any way, key is just used as an example, it can be changed to secretKey in the docs / example

jaruba avatar Feb 27 '24 14:02 jaruba