skipper icon indicating copy to clipboard operation
skipper copied to clipboard

Upgrade skipper click version to latest major

Open omertuc opened this issue 4 years ago • 4 comments

Since skipper is useful to be installed as a system-level package and not just in a virtualenv, the older click version conflicts with other utilities that use newer version of click (such as Black)

This upgrade should fix that conflict. The breaking changes between 6.0 -> 7.0 were changing underscores to dashes by default. Skipper doesn't have any underscores in its subcommands

The breaking changes between 7.0 and 8.0 seem to be just dropping support for Python 3.5 and Python 2.7

So I think this upgrade should be rather seamless

omertuc avatar Aug 02 '21 18:08 omertuc

Dropping support for python 2.7 isn't seamless. Currently, Skipper support Python 2.7, we even use test metrics to validate it. On the other hand, it's 2021, perhaps it's about time. @tsorya @romfreiman @ronniel1 thoughts?

eranco74 avatar Aug 03 '21 13:08 eranco74

@eranco74 Just a reminder another small company uses this project and still need support for python 2.7 :)

roeigo-stratoscale avatar Aug 03 '21 16:08 roeigo-stratoscale

@roeigo-stratoscale that small (and amazing) company owns the master branch.

eranco74 avatar Aug 04 '21 10:08 eranco74

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 22 '24 14:05 sonarqubecloud[bot]