spark-rabbitmq icon indicating copy to clipboard operation
spark-rabbitmq copied to clipboard

Add possibility to specify SSL protocol

Open jniebuhr opened this issue 7 years ago • 7 comments

Fixes #107

jniebuhr avatar Jun 22 '17 11:06 jniebuhr

if (useSslConnection(params)) { factory.useSslProtocol(getSslProtocol(params)) }

shouldn't it be in the addConnection instead of the getChannel ?

nelsou avatar Jun 26 '17 12:06 nelsou

It seems to be a global setting which is not used on the connection but on the factory. So I assumed this was the right spot.

jniebuhr avatar Jun 26 '17 12:06 jniebuhr

Could you add some tests?? I think that you need to initialize the keyManager and the trustManager...

compae avatar Aug 18 '17 07:08 compae

Yes, I'll do that

jniebuhr avatar Aug 18 '17 07:08 jniebuhr

If the test should be some kind of integration test, you'll need to change the jenkins setup to include some RabbitMQ with SSL

jniebuhr avatar Aug 18 '17 07:08 jniebuhr

I've added the tests now. The image I used was https://github.com/roboconf/rabbitmq-with-ssl-in-docker I had to change fail_if_no_peer_cert to false though, which makes sense.

jniebuhr avatar Aug 18 '17 08:08 jniebuhr

A TrustManager instance is added automatically by the driver. I didn't find anything about a KeyManager in the docs, but I assume you'll need that one for client cert auth.

jniebuhr avatar Aug 18 '17 08:08 jniebuhr