spark-rabbitmq
spark-rabbitmq copied to clipboard
Add possibility to specify SSL protocol
Fixes #107
if (useSslConnection(params)) { factory.useSslProtocol(getSslProtocol(params)) }
shouldn't it be in the addConnection instead of the getChannel ?
It seems to be a global setting which is not used on the connection but on the factory. So I assumed this was the right spot.
Could you add some tests?? I think that you need to initialize the keyManager and the trustManager...
Yes, I'll do that
If the test should be some kind of integration test, you'll need to change the jenkins setup to include some RabbitMQ with SSL
I've added the tests now. The image I used was https://github.com/roboconf/rabbitmq-with-ssl-in-docker
I had to change fail_if_no_peer_cert
to false though, which makes sense.
A TrustManager
instance is added automatically by the driver. I didn't find anything about a KeyManager
in the docs, but I assume you'll need that one for client cert auth.