Engine icon indicating copy to clipboard operation
Engine copied to clipboard

Feature: Removal of legacy/unnecessary entities.

Open kittymatthew opened this issue 4 years ago • 2 comments

Which component should be improved?

Entities, namely the removal of many.

Describe your suggestion

Many entities have been copied through codebases and FGDs, finding themselves in modern games. Take env_beverage for example. It was carried over from GoldSource for legacy purposes, and hasn't been used once in decades - the model for it doesn't even come shipped with any games. I can assist with cleaning up factories and the FGD repo, but obviously, I can't remove entities from the code. If entities aren't going to be removed, then authorization to remove them from P2CE's side of the FGD would be appreciated, as they are all very useless. There are many others that would be useful only in HL or L4D, for example, but I'm not sure if those are candidates for removal in P2CE.

Expected result

The following entities to be removed: (keep in mind these are just suggestions!)

Legacy:

  • env_beverage
  • env_movieexplosion
  • game_globalvars
  • info_elevator_floor
  • info_teleporter_countdown
  • info_target_personality_sphere
  • ~~point_bugbait~~
  • point_surroundtest
  • ~~portalmp_gamreules~~
  • test_traceline
  • test_sidelist

kittymatthew avatar Jun 15 '21 19:06 kittymatthew

portalmp_gamerules is required for coop to work, it's just an entity that's not intended for users to do anything with. point_bugbait also isn't obsolete, since P2CE adds the HL2 weapons/npcs. Those test entities are definitely useless, they're only really there to test engine features and I have no idea why they're even compiled into release builds of any game.

TeamSpen210 avatar Jun 15 '21 21:06 TeamSpen210

The test entities should be put behind a development only compile guard.

RealityAnomaly avatar Jul 02 '21 09:07 RealityAnomaly