Engine icon indicating copy to clipboard operation
Engine copied to clipboard

Dedicated server produces duplicate console window

Open vrad-exe opened this issue 2 years ago • 3 comments

Describe the bug

When a dedicated server is run through a batch script, it produces a duplicate console window, which did not happen before. The "old" console window can be closed without issue, but this is still annoying. image

Issue Map

N/A

To Reproduce

  1. Run dedicated server
  2. There is a duplicate console window

Operating System

Tested on Windows 10; possibly Windows specific

vrad-exe avatar Apr 13 '23 04:04 vrad-exe

This is a known issue related to the merged dedicated server now being flagged with the subsytem "Windows" instead of "Console", as the game itself is not a console app. If we tell the launcher to take over the host console, and it wasn't run from a batch file, then it wigs out and allows you to still type in windows commands while the dedicated server is running. It's weird!

ozxybox avatar Apr 13 '23 04:04 ozxybox

The combined dedicated server executable still seems weird to me, not sure what the benefit is - I guess maybe it gets rid of a bit of duplicated code?

vrad-exe avatar Apr 13 '23 22:04 vrad-exe

There was huge amounts of code duplication, and this was the best way to reduce it. Long term duplicate code leads to more issues and a more broken dedicated server when someone forgets to update it. This also gives us nice tools such as a separate console window for the game, which I still need to polish up and merge...

ozxybox avatar Apr 22 '23 06:04 ozxybox