asgs icon indicating copy to clipboard operation
asgs copied to clipboard

rename run.properties key, "Maximum Values Point CSV File Name" to use no spaces and dots

Open wwlwpd opened this issue 5 years ago • 1 comments

@jasonfleming - I was going through the a run.properties file and saw this entry. I think it's a "bug" because the format is not the same as the others. For consistency it should be renamed from Maximum Values Point CSV File Name to something else that follows the same sort of naming that all the others follow. If approve this issue and suggest a property key name, I can fix it.

Here's an example.

time.hpc.job.padcirc.finish : 2020-Jan-22-T14:03:23-0600
time.post.start : 2020-Jan-22-T14:03:56-0600
Maximum Values Point CSV File Name : harvey2017adv16nhcConsensus8000W20Max.csv.gz
Maximum Values Point CSV File Format : gzipped ascii csv
post.opendap.files : ( fort.15 fort.22 fort.61.nc fort.63.nc maxele.63.nc run.properties al092017.fst bal092017.dat fort.74.nc maxwvel.63.nc sendNotification endrisinginun.63.nc everdried.63.nc fort.64.nc fort.68.nc fort.71.nc fort.72.nc fort.73.nc header.csv initiallydry.63.nc inundationtime.63.nc max_data.csv maxinundepth.63.nc maxrs.63.nc maxvel.63.nc minpr.63.nc /scratch1/00976/jgflemin/asgs107826/16/cycle.log /scratch1/00976/jgflemin/asgs107826/16/nhcConsensus8000W20/scenario.log /scratch1/00976/jgflemin/tx2008_r35h_al092017_jgf_scaling.asgs-2020-Jan-21-T10:49:09-0600.107826.log /work/00976/jgflemin/frontera/asgs/jasonfleming/asgs/config/2020/asgs_config_tx2008_r35h_al092017_jgf_scaling.sh )

Here are the spots in the code I found that it's written:

git grep 'Maximum Values Point CSV File Name'
output/cpra_post.sh:#csvFileName=`grep "Maximum Values Point CSV File Name" ${SCENARIODIR}/run.properties | sed 's/Maximum Values Point CS
output/createMaxCSV.sh:echo "Maximum Values Point CSV File Name : ${csvFileName}.gz" >> run.properties
output/hsofs_renci_post.sh:#csvFileName=`grep "Maximum Values Point CSV File Name" ${STORMDIR}/run.properties | sed 's/Maximum Values Poin
output/make_max_csv.sh:echo "Maximum Values Point CSV File Name : ${csvFileName}.gz" >> run.properties
output/ut-post2017.sh:csvFileName=`grep "Maximum Values Point CSV File Name" ${STORMDIR}/run.properties | sed 's/Maximum Values Point CSV 
output/ut-post2018.sh:csvFileName=`grep "Maximum Values Point CSV File Name" ${STORMDIR}/run.properties | sed 's/Maximum Values Point CSV 

wwlwpd avatar Feb 22 '20 23:02 wwlwpd

Thank you for pointing this out ... we need to coordinate metadata changes with downstream consumers (particularly CERA). The metadata is almost like an API at this point, but one that I have not done a good job of documenting. I really need to clean it up.

jasonfleming avatar May 04 '20 15:05 jasonfleming