ros_team_workspace icon indicating copy to clipboard operation
ros_team_workspace copied to clipboard

Dangerous command in create-new-package.bash "rm -r git"

Open DaisukeUra opened this issue 4 years ago • 1 comments

Hello, This software seems to make the development of ROS2 easier, so I am trying it out.

The below block asks for user information on git. https://github.com/StoglRobotics/ros_team_workspace/blob/cd83934e21e2d2a7b4f07dd52a186adb83083066/scripts/create-new-package.bash#L54-L73

However, depending on the answer, the .git directory will be deleted. This may not be a problem in most cases, but it is better to confirm if you are trying to delete an important file.

DaisukeUra avatar Jun 01 '21 10:06 DaisukeUra

Hi @DaisukeUra thanks for the interest. You are right, I am checking this wrong! I should check if there is a git folder in the parent folder...

Thanks for this!

destogl avatar Jul 16 '21 18:07 destogl