AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard

Published 20 hours ago • verified publisher icon StoDevX

Investigate use of Moment's `default` options

Open hawkrives opened this issue 7 years ago • 6 comments

We should look into using Moment.relativeTimeRounding and Moment.relativeTimeThreshold to control the global rounding needs expressed in #that-other-issue. (see also: http://stackoverflow.com/a/42520227/2347774)

As it turns out, Moment Timezone also supports a "default time zone". Which will let us show all of our moments in Central time without having that constant scattered over every file :smile:

hawkrives avatar Mar 02 '17 15:03 hawkrives

Great idea, @hawkrives

drewvolz avatar Mar 02 '17 15:03 drewvolz

As it turns out, Moment Timezone also supports a "default time zone". Which will let us show all of our moments in Central time without having that constant scattered over every file

I'm not sure why we decided to define that more than once.

drewvolz avatar Mar 08 '18 19:03 drewvolz

I know that we're not using the default time zone because we decided that only some views should use Central time; others should use the device time. We could revisit that.

hawkrives avatar Mar 08 '18 20:03 hawkrives

We should revisit that.

drewvolz avatar Mar 08 '18 20:03 drewvolz

Let's revisit that.

hawkrives avatar Mar 08 '18 20:03 hawkrives

Triage: Can someone please find #that-other-issue and update what needs to happen here, or remove this from the v2.8.0 milestone?

rye avatar Sep 07 '19 15:09 rye