AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard

Invocation of non-function in source/views/stoprint/print-jobs.tsx

Open rye opened this issue 3 years ago • 6 comments

I'm going to need some help from @hawkrives on this one, I think!

LGTM found a "Callee is not a function: it has type undefined" correctness hole:

https://lgtm.com/projects/g/StoDevX/AAO-React-Native/snapshot/58f99f6ef922ebb9223429ccf424aa0bfdb491b3/files/source/views/stoprint/print-jobs.tsx

It seems to think I introduced this in 670c2cb47a79ddbb9e733563cdd267e1f1f976ad, but I think the underlying issue was introduced in d4f7d819072b2f435c389b1543f2dab22814f544 with the original addition of the _logInViaCredentials, and it just surfaced with the additional restrictions imposed by TypeScript.

Sure enough, when I launch up the StoPrint view, the app is stuck on the "Fetching a list of stoPrint Jobs..." view, which seems to me to indicate that this log in is never succeeding.

rye avatar Jul 18 '21 18:07 rye

Just to check, you're connected to the Stolaf VPN?

hawkrives avatar Jul 18 '21 18:07 hawkrives

Nope, lol... maybe I should be!

rye avatar Jul 18 '21 18:07 rye

In Settings > Debug, login > status is "logged-in", FWIW.

rye avatar Jul 18 '21 18:07 rye

This also just came through on Sentry:

Screenshot from 2021-07-18 14-02-25

rye avatar Jul 18 '21 19:07 rye

@rye do you see the same outcome after resetting the app and then connecting when on the VPN?

drewvolz avatar Jul 20 '21 00:07 drewvolz

I do get a Connection Issue screen instead of a Fetching screen if I first open settings.

If I reset the app, I'm prompted to log in. If I log in and then go to the stoPrint screen, I get Connection Issue. It's only after the app restarts that this fails, it seems. Force stopping, my login state isn't preserved, but I guess I'd kinda expect the stoPrint screen to do that for me

rye avatar Jul 20 '21 00:07 rye

@drewvolz @rye Do you think this one is still valid? All of the credential handling has been reworked now…

hawkrives avatar Jan 21 '23 04:01 hawkrives

Feel free to close this and we will handle it if Sentry sees it again.

drewvolz avatar Jan 21 '23 05:01 drewvolz