AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard

License viewer

Open drewvolz opened this issue 5 years ago • 8 comments

Integrates the license-checker package in order to parse all of our deps and their licenses.

📸 Screenshots

~ ~
Simulator Screen Shot - iPhone 11 - 2019-11-17 at 12 53 01 Simulator Screen Shot - iPhone 11 - 2019-11-06 at 23 44 40

Todo

  • [ ] Flow types

drewvolz avatar Nov 07 '19 07:11 drewvolz

Codecov Report

Merging #4187 into master will decrease coverage by 0.06%. The diff coverage is 0%.

Impacted file tree graph

codecov[bot] avatar Nov 07 '19 08:11 codecov[bot]

I’d still like to not show any images in the list, but maybe that’s just me.

hawkrives avatar Nov 07 '19 14:11 hawkrives

So… how do I look at a nested dependency’s license? Are they all in one huge giant list?

hawkrives avatar Nov 07 '19 14:11 hawkrives

It’s all one big list at the moment.

drewvolz avatar Nov 07 '19 15:11 drewvolz

I'm happy to remove the images @hawkrives. I'm thinking they're more effort than they're worth.

drewvolz avatar Nov 07 '19 21:11 drewvolz

@drewvolz That's kinda where I'm at. They look nice, but there's a bunch of edge cases, not to mention memory use and rate limiting and bandwidth and…

I'm pretty firmly of the opinion that we should just not show images there.

hawkrives avatar Nov 08 '19 00:11 hawkrives

Also, I was able to successfully run this in an Android emulator just now, and did not encounter any crashes.

rye avatar May 02 '20 18:05 rye

Thinking it could be beneficial to reimplementing this with LicensePlist and be done with it.

drewvolz avatar Apr 14 '22 22:04 drewvolz