AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard

Hours not rendering on view open

Open rye opened this issue 6 years ago • 10 comments

To reproduce:

  1. Reset everything
  2. Force quit app
  3. Open app
  4. Go to Building Hours
  5. List is empty

rye avatar Feb 27 '19 16:02 rye

The network request is not fired off until the timer rolls over, it seems.

rye avatar Feb 27 '19 16:02 rye

(PTR doesn't work.)

rye avatar Feb 27 '19 16:02 rye

I’ve noticed this intermittently. I would say it was a visual blip and the hours loaded after a second on my device.

drewvolz avatar Feb 27 '19 18:02 drewvolz

But I think this is a symptom of our larger caching impl

drewvolz avatar Feb 27 '19 18:02 drewvolz

It's not from caching

hawkrives avatar Feb 27 '19 18:02 hawkrives

Caching always returns some data

hawkrives avatar Feb 27 '19 18:02 hawkrives

I just had this happen to me this morning.

hawkrives avatar Sep 07 '19 18:09 hawkrives

I've noticed a few of our listviews have logic that very briefly shows "list is empty" logic or text before the actual view loads.

drewvolz avatar Sep 07 '19 19:09 drewvolz

I can no longer reproduce this on my device; should we close?

rye avatar Apr 16 '20 15:04 rye

I think this is still happening. A fresh install will show "no hours" as the loading state until we've fetched. It's accurate but not ideal.

drewvolz avatar Apr 23 '22 01:04 drewvolz

I'd like to think that we can close this now - @drewvolz thoughts?

hawkrives avatar Jan 21 '23 05:01 hawkrives

I think we can close it

drewvolz avatar Jan 21 '23 05:01 drewvolz