AAO-React-Native icon indicating copy to clipboard operation
AAO-React-Native copied to clipboard

Published 20 hours ago • verified publisher icon StoDevX

TableView's Section background color is not set properly per platform

Open rye opened this issue 6 years ago • 10 comments

Sad.

rye avatar Nov 08 '18 00:11 rye

I guess we didn't fix that in https://github.com/StoDevX/AAO-React-Native/pull/2987?

drewvolz avatar Nov 08 '18 00:11 drewvolz

Is this still an issue?

drewvolz avatar Mar 17 '19 20:03 drewvolz

@drewvolz yes.

However! I think I know what's causing it now – React Navigation sets a default background color on the views that it manages, and I think that's causing the slight-but-distinct color shift.

I haven't checked this yet, but I think that we can just set {backgroundColor: transparent} on Section for Android. (I haven't just PR'd it, either, because it could well force them to be black backgrounds. Idk.)

hawkrives avatar Mar 25 '19 04:03 hawkrives

Was this not closed by https://github.com/StoDevX/AAO-React-Native/pull/3462?

drewvolz avatar Jul 15 '19 23:07 drewvolz

Nope…

hawkrives avatar Jul 16 '19 11:07 hawkrives

This has since been resolved, so I'm closing this issue.

rye avatar Sep 07 '19 15:09 rye

rye avatar Sep 07 '19 15:09 rye

gah. thanks.

hawkrives avatar Sep 07 '19 16:09 hawkrives

With the addition of #5947, this now also impacts iOS.

drewvolz avatar Apr 24 '22 22:04 drewvolz

I think we can point to sectionTintColor just from a cursory search

https://github.com/StoDevX/AAO-React-Native/blob/be76795620386279ecd48422840da039829eae35/modules/tableview/index.tsx#L11-L19

In most cases we've assigned this to a platform color

https://github.com/StoDevX/AAO-React-Native/blob/134a85fc7bec1276aba056e7231f98a1cd7bc36c/modules/colors/platform.js#L23-L24

and react-native-tableview-simple's default tint color is #EFEFF4 which is what is showing up around the app.

Do we want to set the tint color to be transparent (removing it) or change it to match the background of our views? What is the best way forward here?

drewvolz avatar May 30 '22 00:05 drewvolz