Multi-tool bug with dropping files

Open dhenry437 opened this issue 1 year ago • 5 comments

This should fix a bug I found where the PDF Multi-tool filename input box would not update and remain disabled when dragging a file in but not when using the filepicker.

License Agreement for Contributions

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Jan 18 '24 01:01 dhenry437

This change doesn't seem to be working on my end. I'm using Edge with version 120.0.2210.133.

Jan 18 '24 04:01 sbplat

If everything is still functional then this LGTM.

Jan 18 '24 06:01 sbplat

only tested in chrome while working on it, but just checked and it works for my Edge v120.0.2210.133

also seen your change, i will be more descriptive in the future

Jan 18 '24 08:01 dhenry437

I am not exactly sure how it was working on your end. The comments I just left above highlight some potential issues that could break functionality. It would be beneficial to test it and ensure everything related to the change still works as expected before proceeding with a PR.

Also, in the future, could you please create an issue relating to this bug first? Thanks!

Jan 18 '24 14:01 sbplat

So from what I can see you fixed-up all my poor code? Thankyou. I'll take all your points into consideration in future.

Jan 19 '24 02:01 dhenry437