Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

Add SemVer docker tags

Open RoboMagus opened this issue 7 months ago • 1 comments

Description of Changes

This PR adds SemVer tags to published docker images.

Closes #1771, which has been open for a while and has not been picked up yet.


Checklist

General

Documentation

UI Changes (if applicable)

  • [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • [x] I have tested my changes locally. Refer to the Testing Guide for more details.

[!NOTE]
The scope of this PR falls outside the tests provided by this repository. Instead, to validate the proposed changes work as intended, a test workflow run was performed. See results here. The workflow has been manually canceled after the Generate tags step was completed. The snippet below shows the resulting docker tags of this test run:


▼ Docker image version
  0.45.6
▼ Docker tags
  ***/s-pdf:0.45.6
  ***/s-pdf:0.45
  ***/s-pdf:0
  ***/s-pdf:latest
  ***/s-pdf:latest
  ghcr.io/***/s-pdf:0.45.6
  ghcr.io/***/s-pdf:0.45
  ghcr.io/***/s-pdf:0
  ghcr.io/***/s-pdf:latest
  ghcr.io/***/s-pdf:latest
  ghcr.io/***/stirling-pdf:0.45.6
  ghcr.io/***/stirling-pdf:0.45
  ghcr.io/***/stirling-pdf:0
  ghcr.io/***/stirling-pdf:latest
  ghcr.io/***/stirling-pdf:latest
  ***/stirling-pdf:0.45.6
  ***/stirling-pdf:0.45
  ***/stirling-pdf:0
  ***/stirling-pdf:latest
  ***/stirling-pdf:latest

RoboMagus avatar Apr 25 '25 14:04 RoboMagus

Kept this open for now for internal discussion on how many versions we want Currently this would create 0.45 0 0.45.6-fat 0.45-fat 0-fat 0.45.6-ultra-lite 0.45-ultra-lite 0-ultra-lite latest latest-fat latest-ultra-lite

Wondering if we remove -fat image type

will keep this open while team decides and merge after, thanks for this work!

Frooodle avatar Apr 30 '25 19:04 Frooodle

Closing for now, will pick up this functionality for our V2 release

Frooodle avatar Jul 22 '25 08:07 Frooodle

@Frooodle, is there an ETA on the v2 release cycle? (Seeing as you've only just achieved v1).

This PR would greatly help users deal with version management of their deployments and have little to no impact on the actual functionality of the application itself.

Delaying the merger of this kind of PR until the first major release is quite understandable, but to me there is no logic behind postponing it to v2. I hope you can share some reasoning for this decision.

RoboMagus avatar Jul 23 '25 09:07 RoboMagus