Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

Multi tool select buttons bug

Open JoseQuintas2003 opened this issue 8 months ago • 8 comments

Description of Changes

Changes:

  • In the multitool page, the behavior of the "Select/Deselect All" buttons was changed so that if no pages are selected, then the "Deselect All" button is disabled, and if all pages are selected, then the "Select All" button is disabled.
  • These buttons will also appear if the "Page Select" is turned on, either by pressing the "Page Select" button or manually selecting one page.
  • Furthermore, a bug that caused the pages to remain selected when "Page Select" is off was also fixed

Why the changes were made:

  • The multitool did not allow the "Select All" or "Deselect All" button to appear simultaneously. The multitool was relying on a toggle mechanic for the Page Selection and this could prevent the user from selecting or deselecting all pages as intended, if they manually select/deselect one or more pages.

Other challenges:

  • No particular challenges encountered

Relevant Screenshots:

Screenshot_1 Fig. 1 - Only "Select All" button appears when Page Select is turned on, since no pages are selected

Screenshot_2 Fig. 2 - Both "Select All" and "Deselect All" buttons appear when one or more, but not all pages are selected

Screenshot_3 Fig. 3 - Only "Deselect All" button appears when all pages are selected

Screenshot_4 Fig. 4 - When Page Select is turned off, both "Select All" and "Deselect All" buttons disappear and all pages are deselected

Closes #3206


Checklist

General

Documentation

UI Changes (if applicable)

  • [x] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • [x] I have tested my changes locally. Refer to the Testing Guide for more details.

JoseQuintas2003 avatar Apr 23 '25 10:04 JoseQuintas2003

/deploypr

ConnorYoh avatar Apr 23 '25 12:04 ConnorYoh

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404 Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

stirlingbot[bot] avatar Apr 23 '25 12:04 stirlingbot[bot]

Hey there, great to receive some feedback on my work so far. I'm surprised I didn't notice these bugs, but I suppose it's normal some things might have gone unnoticed. I'll begin making the corrections asap. Thank you for your detailed feedback.

JoseQuintas2003 avatar Apr 23 '25 12:04 JoseQuintas2003

Hey there once more @ConnorYoh. I believe I have solved the problems you mentioned in these 3 commits. I hope nothing has escaped me this time, but if there's anything I can help with or improve, then just let me know. Talk to you soon!

JoseQuintas2003 avatar Apr 23 '25 15:04 JoseQuintas2003

/deploypr

ConnorYoh avatar Apr 24 '25 08:04 ConnorYoh

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404 Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

stirlingbot[bot] avatar Apr 24 '25 08:04 stirlingbot[bot]

Hey there @ConnorYoh. So sorry I missed that. It seems its a simple solution as you suggested, I'll take care of it.

JoseQuintas2003 avatar Apr 26 '25 16:04 JoseQuintas2003

@ConnorYoh its done. Hopefully this clears everything. Thanks for the help. I apologize if this took longer than necessary.

JoseQuintas2003 avatar Apr 26 '25 16:04 JoseQuintas2003

/deploypr

ConnorYoh avatar Apr 28 '25 10:04 ConnorYoh

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404 Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

stirlingbot[bot] avatar Apr 28 '25 10:04 stirlingbot[bot]