Multi tool select buttons bug
Description of Changes
Changes:
- In the multitool page, the behavior of the "Select/Deselect All" buttons was changed so that if no pages are selected, then the "Deselect All" button is disabled, and if all pages are selected, then the "Select All" button is disabled.
- These buttons will also appear if the "Page Select" is turned on, either by pressing the "Page Select" button or manually selecting one page.
- Furthermore, a bug that caused the pages to remain selected when "Page Select" is off was also fixed
Why the changes were made:
- The multitool did not allow the "Select All" or "Deselect All" button to appear simultaneously. The multitool was relying on a toggle mechanic for the Page Selection and this could prevent the user from selecting or deselecting all pages as intended, if they manually select/deselect one or more pages.
Other challenges:
- No particular challenges encountered
Relevant Screenshots:
Fig. 1 - Only "Select All" button appears when Page Select is turned on, since no pages are selected
Fig. 2 - Both "Select All" and "Deselect All" buttons appear when one or more, but not all pages are selected
Fig. 3 - Only "Deselect All" button appears when all pages are selected
Fig. 4 - When Page Select is turned off, both "Select All" and "Deselect All" buttons disappear and all pages are deselected
Closes #3206
Checklist
General
- [x] I have read the Contribution Guidelines
- [x] I have read the Stirling-PDF Developer Guide (if applicable)
- [ ] I have read the How to add new languages to Stirling-PDF (if applicable)
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings
Documentation
- [ ] I have updated relevant docs on Stirling-PDF's doc repo (if functionality has heavily changed)
- [ ] I have read the section Add New Translation Tags (for new translation tags only)
UI Changes (if applicable)
- [x] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)
Testing (if applicable)
- [x] I have tested my changes locally. Refer to the Testing Guide for more details.
/deploypr
🚀 PR Test Deployment
Your PR has been deployed for testing!
🔗 Test URL: http://185.252.234.121:3404 Security Disabled
This deployment will be automatically cleaned up when the PR is closed.
Hey there, great to receive some feedback on my work so far. I'm surprised I didn't notice these bugs, but I suppose it's normal some things might have gone unnoticed. I'll begin making the corrections asap. Thank you for your detailed feedback.
Hey there once more @ConnorYoh. I believe I have solved the problems you mentioned in these 3 commits. I hope nothing has escaped me this time, but if there's anything I can help with or improve, then just let me know. Talk to you soon!
/deploypr
🚀 PR Test Deployment
Your PR has been deployed for testing!
🔗 Test URL: http://185.252.234.121:3404 Security Disabled
This deployment will be automatically cleaned up when the PR is closed.
Hey there @ConnorYoh. So sorry I missed that. It seems its a simple solution as you suggested, I'll take care of it.
@ConnorYoh its done. Hopefully this clears everything. Thanks for the help. I apologize if this took longer than necessary.
/deploypr
🚀 PR Test Deployment
Your PR has been deployed for testing!
🔗 Test URL: http://185.252.234.121:3404 Security Disabled
This deployment will be automatically cleaned up when the PR is closed.