Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

[Feature Request]: Hide Stirling PDF banners when on local install

Open Frooodle opened this issue 8 months ago • 5 comments

Feature Description

Hide Stirling PDF banners when on local install

Image

Why is this feature valuable?

No response

Suggested Implementation

No response

Additional Information

No response

No Duplicate of the Feature

  • [x] I have verified that there are no existing features requests similar to my request.

Frooodle avatar Apr 17 '25 15:04 Frooodle

If it's okay, you can assign this task to me. Do we have any idea on how to detect whether it's a local installation? For example, are we planning to manage it through something like a Docker environment variable, or are we thinking of a structure where we simply hide it if it's running in a containerized environment?

muratcanyeldan avatar Apr 20 '25 12:04 muratcanyeldan

So had a bit more thinking on this These banners serve the same purpose of asking the user for consent on analytics, the middle Modal is for server analytics and the bottom cookie consent is for web analytics. The Server analytics is presented to the first user that connects as it assumes they are admin

I think for the first ever use we can do If server analytics prompt is showing, then hide cookie consent analytics. And whatever server analytics consent is selected (enable or disable) then the same is selected for the cookie consent, no need for this duplication of banners

Frooodle avatar Apr 20 '25 12:04 Frooodle

Also fyi by local i misspoke i meant non server installation, which can be done by detecting the flag BROWSER_OPEN But that's unrelated now since we should still ask for consent of these users

Frooodle avatar Apr 20 '25 12:04 Frooodle

Okay thank you for explanation. I can work on this if it's okay

muratcanyeldan avatar Apr 20 '25 13:04 muratcanyeldan

Absolutely!

Frooodle avatar Apr 20 '25 13:04 Frooodle