Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

feat(pdf-multi-tool):PDF Multi-tool to use new file input box

Open Chirag-S-Kotian opened this issue 10 months ago • 15 comments

Description:
This PR updates the PDF Multi-tool to use the newly introduced file input box, improving the user experience and maintaining consistency across the platform.

Changes Introduced:

  • Replaces the old file input mechanism with the new file input box.
  • Ensures seamless integration with existing functionalities.
  • Refactors related code for better maintainability.

Why is this valuable?

  • Enhances user experience by adopting a standardized file input mechanism.
  • Improves accessibility and usability of the PDF Multi-tool.
  • Aligns the component with recent UI/UX improvements.

References:
Closes #2385

Testing Steps:

  • Navigate to the PDF Multi-tool.
  • Upload a file using the new file input box.
  • Verify that all existing functionalities work as expected.

Chirag-S-Kotian avatar Feb 16 '25 16:02 Chirag-S-Kotian

/deploypr

Frooodle avatar Feb 16 '25 17:02 Frooodle

What is this means?? @Frooodle

Chirag-S-Kotian avatar Feb 16 '25 23:02 Chirag-S-Kotian

Please ignore, it's a internal command we use for validations and testing

Frooodle avatar Feb 16 '25 23:02 Frooodle

Hy @Frooodle is my pr changes are good ? Or not?

Chirag-S-Kotian avatar Feb 17 '25 02:02 Chirag-S-Kotian

Will be reviewed today will let you know

Frooodle avatar Feb 17 '25 10:02 Frooodle

/deploypr

Frooodle avatar Feb 18 '25 12:02 Frooodle

is it working or not??

Chirag-S-Kotian avatar Feb 18 '25 12:02 Chirag-S-Kotian

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2960

This deployment will be automatically cleaned up when the PR is closed.

github-actions[bot] avatar Feb 18 '25 12:02 github-actions[bot]

Seems that multi-tool is getting an error on the test deployment (also sorry for delay had to finish another PR to allow this to build due to a update on docker dependency side, when we review we will message no need to keep asking)

http://185.252.234.121:2960/multi-tool throws Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING

which normally means a thymeleaf rending error in logs I see

Caused by: org.thymeleaf.exceptions.TemplateInputException: Error resolving fragment: "~{'fragments/common' : : modernFileSelector (name='fileInput',multipleInputsForSingleRequest=true,accept='application/pdf')}": templ ate or fragment could not be resolved (template: "multi-tool" - line 25, col 24)

Frooodle avatar Feb 18 '25 12:02 Frooodle

@Chirag-S-Kotian Any updates?

Frooodle avatar Feb 21 '25 16:02 Frooodle

hy i tried my best to fix the error let me know if you face any other errors or similar errors

Chirag-S-Kotian avatar Feb 21 '25 16:02 Chirag-S-Kotian

/deploypr

Frooodle avatar Feb 22 '25 01:02 Frooodle

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2960

This deployment will be automatically cleaned up when the PR is closed.

github-actions[bot] avatar Feb 22 '25 01:02 github-actions[bot]

@Chirag-S-Kotian Have you tested the functionality at all? From what I can see you input a file and it doesn't load within the UI at all and doesn't load the pages

(or at least it doesn't work on my browser for some reason?)

Frooodle avatar Feb 22 '25 10:02 Frooodle

Give me some time brother I will look into it and will update you.

Chirag-S-Kotian avatar Feb 23 '25 03:02 Chirag-S-Kotian

@Chirag-S-Kotian Hows it going, any issues we can help with?

Frooodle avatar Mar 02 '25 17:03 Frooodle

Sorry bro I can't continue I don't know how to start development server on this so I want to quit 😞

Chirag-S-Kotian avatar Mar 02 '25 17:03 Chirag-S-Kotian