Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

Feature/1976/multi tool multiple pages

Open reecebrowne opened this issue 1 year ago • 6 comments

Description

Allow user to select pages and perform rotate/delete/download operations on only the selected pages

Closes #(1976) image

Checklist

  • [X] I have read the Contribution Guidelines
  • [X] I have performed a self-review of my own code
  • [X] I have attached images of the change if it is UI based
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] My changes generate no new warnings
  • [X] I have read the section Add New Translation Tags (for new translation tags only)

reecebrowne avatar Nov 08 '24 15:11 reecebrowne

image This doesnt really match the rest of the UI much, should we just add icon + tooltip? Google uses this for select all select_all_24dp_E8EAED_FILL0_wght400_GRAD0_opsz24 Or we can use something like https://fonts.google.com/icons?selected=Material+Symbols+Outlined:checklist_rtl:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=select&icon.size=24&icon.color=%23e8eaed Also can you explain what select pages does vs select all?

Frooodle avatar Nov 08 '24 17:11 Frooodle

image This doesnt really match the rest of the UI much, should we just add icon + tooltip? Google uses this for select all select_all_24dp_E8EAED_FILL0_wght400_GRAD0_opsz24 Or we can use something like https://fonts.google.com/icons?selected=Material+Symbols+Outlined:checklist_rtl:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=select&icon.size=24&icon.color=%23e8eaed Also can you explain what select pages does vs select all?

I think the whole page needs a tooltip pass on it so I could have a rethink as part of that? Select pages activates the page selection mode essentially (definitely should be an icon to fit with the current UI but I wasn't really happy that it got the point across) select all toggles all the checkboxes as you'd expect.

reecebrowne avatar Nov 08 '24 17:11 reecebrowne

https://github.com/Stirling-Tools/Stirling-PDF/issues/2195 I thought that yesterday 😂

Frooodle avatar Nov 08 '24 18:11 Frooodle

could i contribute some to it

linhexu avatar Nov 09 '24 06:11 linhexu

could I contribute some to it

Hey mate. I'm already most of the way through sorting the icons for the multi-page select features and have included tooltips in doing so but you're more than welcome to do pick up #2195 and sort tooltips for the existing icons.

reecebrowne avatar Nov 09 '24 18:11 reecebrowne

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the pr-branch - Checking the pr-branch

🗂️ Checking File: messages_ar_AR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_bg_BG.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ca_CA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_cs_CZ.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_da_DK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_de_DE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_el_GR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_en_US.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_es_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_eu_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_fr_FR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ga_IE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hi_IN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hr_HR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hu_HU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_id_ID.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_it_IT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ja_JP.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ko_KR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_nl_NL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_no_NB.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pl_PL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_BR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_PT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ro_RO.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ru_RU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sk_SK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sr_LATN_RS.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sv_SE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_th_TH.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_tr_TR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_uk_UA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_vi_VN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_CN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_TW.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

✅ Overall Check Status: Success

github-actions[bot] avatar Nov 12 '24 10:11 github-actions[bot]