Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

Added feature to save pdfs to ram or files dynamically

Open HimaGirija99 opened this issue 1 year ago • 2 comments

Description

  1. Added Memory Limit Configuration: Integrated memory limit settings into the custom_settings.yml file within the configs directory.
  2. Configured Memory Settings Loader: Set up and loaded memory settings in the memoryConfig file using a YAML parser
  3. Implemented Logic in MemoryUtils: Developed logic within the memoryUtils class to determine whether to use file-based storage or in-memory processing based on the configured memory thresholds and available system resources.
  4. Utilized MemoryUtils in PDF Processing: Applied the memoryUtils logic within a Java class responsible for saving PDFs, ensuring efficient memory usage during file processing.
  5. Enhanced Exception Handling: Added comprehensive exception handling in the image extraction method to manage errors more effectively during PDF processing.

I tried implementing the feature for single Java file - ExtractImagesController

Closes #(1775)

Checklist:

  • [x ] I have read the Contribution Guidelines
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] My changes generate no new warnings

HimaGirija99 avatar Sep 02 '24 07:09 HimaGirija99

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the main-branch - Checking the pr-branch

🗂️ Checking File: messages_ar_AR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ar_AR.properties!

🗂️ Checking File: messages_bg_BG.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_bg_BG.properties!

🗂️ Checking File: messages_ca_CA.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ca_CA.properties!

🗂️ Checking File: messages_cs_CZ.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_cs_CZ.properties!

🗂️ Checking File: messages_da_DK.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_da_DK.properties!

🗂️ Checking File: messages_de_DE.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_de_DE.properties!

🗂️ Checking File: messages_el_GR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_el_GR.properties!

🗂️ Checking File: messages_en_US.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_en_US.properties!

🗂️ Checking File: messages_es_ES.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_es_ES.properties!

🗂️ Checking File: messages_eu_ES.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_eu_ES.properties!

🗂️ Checking File: messages_fr_FR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_fr_FR.properties!

🗂️ Checking File: messages_ga_IE.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ga_IE.properties!

🗂️ Checking File: messages_hi_IN.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_hi_IN.properties!

🗂️ Checking File: messages_hr_HR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_hr_HR.properties!

🗂️ Checking File: messages_hu_HU.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_hu_HU.properties!

🗂️ Checking File: messages_id_ID.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_id_ID.properties!

🗂️ Checking File: messages_it_IT.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_it_IT.properties!

🗂️ Checking File: messages_ja_JP.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ja_JP.properties!

🗂️ Checking File: messages_ko_KR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ko_KR.properties!

🗂️ Checking File: messages_nl_NL.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_nl_NL.properties!

🗂️ Checking File: messages_no_NB.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_no_NB.properties!

🗂️ Checking File: messages_pl_PL.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_pl_PL.properties!

🗂️ Checking File: messages_pt_BR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_pt_BR.properties!

🗂️ Checking File: messages_pt_PT.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_pt_PT.properties!

🗂️ Checking File: messages_ro_RO.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ro_RO.properties!

🗂️ Checking File: messages_ru_RU.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_ru_RU.properties!

🗂️ Checking File: messages_sk_SK.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_sk_SK.properties!

🗂️ Checking File: messages_sr_LATN_RS.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_sr_LATN_RS.properties!

🗂️ Checking File: messages_sv_SE.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_sv_SE.properties!

🗂️ Checking File: messages_th_TH.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_th_TH.properties!

🗂️ Checking File: messages_tr_TR.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_tr_TR.properties!

🗂️ Checking File: messages_uk_UA.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_uk_UA.properties!

🗂️ Checking File: messages_vi_VN.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_vi_VN.properties!

🗂️ Checking File: messages_zh_CN.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_zh_CN.properties!

🗂️ Checking File: messages_zh_TW.properties...

  • Test 1 Status: ❌ Failed
    • Issue: Missing lines! Comments, empty lines, or translation strings are missing. Details: 1154 (reference) vs 1153 (current).
  • Test 2 Status: ❌ Failed
    • Issue: There are keys in messages_en_GB.properties addPageNumbers.fontName, addPageNumbers.fontSize that are not present in messages_zh_TW.properties!

❌ Overall Check Status: Failed

github-actions[bot] avatar Sep 03 '24 09:09 github-actions[bot]

sure thank you

HimaGirija99 avatar Sep 05 '24 01:09 HimaGirija99

This still doesn't pass the tests, please either resolve the issue or close PR, remerging is just taking up CPU cycles

Frooodle avatar Sep 23 '24 10:09 Frooodle