Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

User Friendly Merge File Selction

Open t71rs opened this issue 1 year ago • 2 comments

Regarding reverted PR #1204

This PR implements the same changes as the one mentioned above. But it distinguishes file input forms by using the multiple variable of the form. As of right now merge is the only page where these changes are useful in my opinion. If in the future a feature is implemented where these changes are useful, they can be used by setting multiple to true in the Form. At this moment the pipeline page is the only other page where multiple is set to true, but since these changes would not be user friendly for the pipeline page I made sure it is not affected. Also I made sure that the Duplicate warning is dynamic and translatable this time.

Checklist:

  • [X] I have read the Contribution Guidelines
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

t71rs avatar Jul 09 '24 12:07 t71rs

Sorry for taking so long to look at these, its awkward to find time recently to download someone else's repo and build image etc to test before merge need to setup github workspaces :D

Frooodle avatar Aug 03 '24 09:08 Frooodle

Just been testing this, i think we need to add a clear all/ delete all button, the only away to restart is to refresh the whole page which I think many won't do/ bad UX. what do you think? Duplicate warning didn't work for me but I think that's fine regardless,

Frooodle avatar Aug 06 '24 08:08 Frooodle

Closing as outdated due to updated file input

Frooodle avatar Jan 19 '25 18:01 Frooodle