Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

[DRAFT] [Help wanted] Sign zoom handles

Open t71rs opened this issue 1 year ago • 0 comments

Sign Zoom Handles

Opening this Draft PR regarding the issue #1247 . I implemented a basic zoom functionality but have not been able to get the calculation of the position 100% correct when the signature is placed while zooming. (Placement is correct when no zoom is used) Here is an example of what i mean:

image As you can see the signature is alittle bit to high and a little bit too far left. This error is getting worse with increasing zoom. At this point i do not have an explanation for it anymore. So if anyone would like to pick this up and work on it, please do!

This is how i am calculating the position: (example for x coordinate) image The Blue Part is the actual Document. The white part is the part of the document that is visible in the viewport when you are zooming.

I would be happy about some help or as I already said if some one wants to work on this it would be fine for me as well.

Checklist:

  • [X] I have read the Contribution Guidelines
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

t71rs avatar Jun 17 '24 07:06 t71rs