Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

User Friendly Merge File Selection

Open t71rs opened this issue 1 year ago • 2 comments

User Friendly Merge File Selction

If you had already added files to Merge them, but forgot one or more files and you went ahead and pressed the "Select Files" button, all previously selected Files were deleted. I fixed that and made it possible to add Files "File by File". Additionally if someone should add the same File twice, a duplicate warning is now displayed, which is removed, if the duplicates are removed. Merging duplicates is possibel though if someone should want to do that. To work with duplicates I added a unique id for each added FIle in the merging process. This makes it possible to differ between files that have the same Name.

Closes #1174

Checklist:

  • [X] I have read the Contribution Guidelines
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

t71rs avatar May 14 '24 07:05 t71rs

UI has been updated can you confirm this works with latest updates

Frooodle avatar May 18 '24 23:05 Frooodle

Yes I have just tested it locally with the new UI (looks very nice btw :) ) and it still works!

t71rs avatar May 21 '24 09:05 t71rs

This has broken logic for ALL other form inputs with files, now each forms inputs doesnt wipe the previous causing very bad usage for others

Frooodle avatar May 23 '24 18:05 Frooodle

reverting until it can be fixed! :)

Frooodle avatar May 23 '24 18:05 Frooodle

Damn I'm sorry, I will look into it and think of a solution that wont affect anything else since I quite liked this change.

t71rs avatar May 24 '24 07:05 t71rs