Stirling-PDF icon indicating copy to clipboard operation
Stirling-PDF copied to clipboard

Bump org.bouncycastle:bcpkix-jdk18on from 1.77 to 1.78.1

Open dependabot[bot] opened this issue 1 year ago • 8 comments

Bumps org.bouncycastle:bcpkix-jdk18on from 1.77 to 1.78.1.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Apr 21 '24 22:04 dependabot[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 21 '24 22:04 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 09 '24 14:06 sonarqubecloud[bot]

I wonder why updates are not being (auto-) merged as soon as possible... 3 vulnerability fixes in this Cryptography PR alone: https://mvnrepository.com/artifact/org.bouncycastle/bcpkix-jdk18on

reneleonhardt avatar Aug 04 '24 12:08 reneleonhardt

Our automated tests do not currently test the features that use this dependency (cert signing) We don't want to merge anything which will break functionality Until we have a full test suite no auto merging will be happening

Frooodle avatar Aug 04 '24 12:08 Frooodle

Instead of waiting for a full test suite you could manually test this, why do you think a minor dependency update is a breaking update? 🤔 Your users can only run a latest Docker image built 3 months ago containing 36 vulnerabilities which all have been fixed ready for the taking...

reneleonhardt avatar Aug 04 '24 13:08 reneleonhardt

Anyone is welcome to manually test it for me :)

Frooodle avatar Aug 04 '24 15:08 Frooodle

I do want to spend time getting these merged but this whole project is done in spare time And since most users use this either locally or via VPN it has less priority to bugs

Frooodle avatar Aug 04 '24 16:08 Frooodle

I know that most users don't appreciate all the work through donations 🙁 If it would be my project I would fix the dozens of bugs I know of easily (by [auto-] merging Dependabot updates) instead of waiting for bugs caused by updates which may never happen 😅

reneleonhardt avatar Aug 05 '24 07:08 reneleonhardt

@reneleonhardt https://github.com/Stirling-Tools/Stirling-PDF/blob/main/build.gradle#L173 seems this was updated 2 months ago anyway by user and this is just bad conflict

Frooodle avatar Aug 08 '24 20:08 Frooodle

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Aug 08 '24 20:08 dependabot[bot]