stingray icon indicating copy to clipboard operation
stingray copied to clipboard

Check that all notebooks run with the latest version of the code

Open matteobachetti opened this issue 1 year ago • 8 comments

As the title says.

matteobachetti avatar Feb 15 '24 09:02 matteobachetti

Greetings @matteobachetti, While checking the notebooks, i found an import error(?) and raised a PR please verify it and let me know if we have to find similar errors and raise PR accordingly. Edit: Fixed nearly all the Notebooks and help needed to replicate files used in some of the Notebooks, refer commits Thankyou

AnonymousCodes911 avatar Feb 15 '24 11:02 AnonymousCodes911

Hello @matteobachetti , I was going through the notebooks. Are only problems associated with the code are to be considered for a request or something as trivial as a spelling mistake should also be considered?

kartikmandar avatar Feb 16 '24 14:02 kartikmandar

@kartikmandar spelling mistakes surely need to be fixed. Please try to reduce the changes to the bare minimum (e.g. do not re-run full notebooks for changes to the Markdown text)

matteobachetti avatar Feb 16 '24 20:02 matteobachetti

Sure @matteobachetti I will keep that in mind.

kartikmandar avatar Feb 16 '24 20:02 kartikmandar

Hello @matteobachetti I checked all the notebooks extensively and apart from the issues AnonymousCodes911 and I solved, everything was working fine. Also there still some warning messages to solve in LombScargle notebook and some issues in Pulsar notebook.

kartikmandar avatar Feb 23 '24 17:02 kartikmandar