stingray icon indicating copy to clipboard operation
stingray copied to clipboard

add cross-correlation functionality to accept CrossSpectrum objects?

Open davis191 opened this issue 6 years ago • 6 comments

Hi,

Currently, the cross-correlation function only accepts two lightcurve objects. It would help to have the option to have an Average/Crossspectrum object be a potential input as well.

pinging: @abigailStev @swapsha96

davis191 avatar Aug 08 '19 20:08 davis191

Also pinging @dhuppenkothen @matteobachetti

swapsha96 avatar Aug 09 '19 19:08 swapsha96

Thanks @davis191, good suggestion. I don't personally know when I'll have the time to work on this, but if you and/or someone else come out with an implementation I can help adapting it to our code.

matteobachetti avatar Aug 14 '19 09:08 matteobachetti

Where does one begin to implement it? Any details?

swapsha96 avatar Aug 14 '19 16:08 swapsha96

Isn't the cross correlation just the inverse Fourier transform of the cross spectrum? If so, the implementation should be very straightforward. The relevant class is in stingray/crosscorrelation.py. We could modify the __init__ method to allow a cross spectrum object.

matteobachetti avatar Aug 16 '19 12:08 matteobachetti

Yeah! It should be fairly simple. I can give it a go this afternoon!

davis191 avatar Aug 16 '19 14:08 davis191

Hi , has this issue been solved?

mohamedmostafadawood avatar Apr 04 '22 11:04 mohamedmostafadawood