HENDRICS icon indicating copy to clipboard operation
HENDRICS copied to clipboard

Identifying Lightcurve inputs in HENreadevents, and modifying the user warning.

Open Sudarshan-21 opened this issue 8 months ago • 2 comments

Fixes issue #129

Description: This enhancement ensures that, if user inputs a Lightcurve, it will first identify, it is a lightcurve, and will notify the user about it, further, it will ask the user, whether or not to proceed, as shown in the attached image. Depending on the chosen option, the file reading or aborting the process will be done.

Current Behavior

At the moment, HENreadevents reads a FITS light curve with just a mild warning. It should realize if it is a light curve, and give a stronger warning or just fail.

Enhanced Behavior Screenshot from 2025-04-16 23-49-22

PS: The previous PR is closed, since I was having some conflicts with that forked repo.

Sudarshan-21 avatar Apr 18 '25 23:04 Sudarshan-21

@Sudarshan-21 thanks for your PR this looks good to me but we have take care of NICER datas handling that is going to handle by stingray (I have lefted some comments ). And also include some checks and tests as per the contributing guidelines. @matteobachetti your review required

kashish2210 avatar Apr 21 '25 07:04 kashish2210

@kashish2210, thank you for the suggestions!! I will review them and try to make the necessary changes.

Sudarshan-21 avatar Apr 22 '25 17:04 Sudarshan-21