restinio icon indicating copy to clipboard operation
restinio copied to clipboard

Running on 32-bit system causes Narrowing Conversion error

Open TremblingOdin opened this issue 5 years ago • 3 comments

I installed the restinio:x86-windows vcpkg and after it built fine, running it created the following error: restinio\impl\parser_callbacks.ipp(163): error C2397: conversion from 'uint64_t' to 'size_t' requires a narrowing conversion

The 64 bit version works fine, but I would like to also be able to run on 32 bit systems since some companies still use legacy hardware

If you do not intend to support 32 bit that is understandable and just let me know

TremblingOdin avatar Aug 26 '20 21:08 TremblingOdin

Thanks for reporting this issue.

We don't test RESTinio in 32-bit mode usually, but I know that RESTinio works in 32-bit environment (GCC reports warning, not error for that line).

I'll fix the code in parser_callbacks.ipp in the near future.

eao197 avatar Aug 27 '20 16:08 eao197

I've made some fixes in 0.6-dev branch.

I have no plans to release those updates as a new version. I want those changes will be a part of the upcoming v.0.6.11, but there is no planned release date yet.

If this issue is critical to you then let me know, I'll release 0.6.10.1.

eao197 avatar Aug 28 '20 11:08 eao197

It's not a choke point, and there is a work around, but wanted to make an issue so that as I kept up to date with Restinio I wouldn't have to keep redoing the work around. Thank you very much.

TremblingOdin avatar Aug 28 '20 22:08 TremblingOdin