GameYob icon indicating copy to clipboard operation
GameYob copied to clipboard

Sound Issues

Open ghost opened this issue 12 years ago • 14 comments

This occurs after version 0.3-133

Whenever loading new background music, there is a slight static output. This tends to happen a lot in all of the Pokemon games, and in Wario Land 3.

ghost avatar May 31 '13 18:05 ghost

I can't hear what you're describing. Wario Land 3's titlescreen sounds a bit different now, since the white noise is audible, and it's closer to the original. But I'm not sure what you mean by "static". They don't seem to sound any worse than before. Do you mean you're hearing something when no music is playing?

Stewmath avatar Jun 01 '13 05:06 Stewmath

Nevermind, I've noticed this in the gen II pokemon games, but not in gen I.

Stewmath avatar Jun 01 '13 05:06 Stewmath

I've attempted to do something about the clickiness (or static output or whatever it is) in 0.4. It does exist to an extent on real hardware, unfortunately. I've yet to find an emulator which emulates it correctly. Previously the clicks were emulated as in bgb. Now, it's closer to vba's behaviour.

Stewmath avatar Jul 17 '13 20:07 Stewmath

Same thing occurs on latest build from july 3rd (2014) If I were you I'd put this on your top todo list, because I can not stand this crackling/static, it's horrible, for me it's unplayable as in I'm going back to lameboy until this is fixed.

purpasmart96 avatar Sep 17 '14 05:09 purpasmart96

Assuming we're on the same page here, this "clicking" was put in intentionally. It occurs when the global volume changes. It was implemented to support complex sound effects such as in Warlocked.

If you have a gameboy color, it would be appreciated if you could check whether the clicking exists on real hardware. It should. Oddly though, when I tested with Pokemon Crystal, I found that it wasn't really noticeable on a Gameboy SP, but it did exist on a Gameboy Color.

Maybe I'll make a whitelist for games which need this effect for their sound effects. Though I'd rather not for fear of missing one.

In the meantime, if you can compile, commenting out lines 261-262 in "arm7/source/sound.c" should get rid of the effect. That is, comment these lines:

SCHANNEL_CR(1) = SCHANNEL_ENABLE | SOUND_VOL(0) | 
    SOUND_PAN(64) | (0 << 29) | SOUND_REPEAT;

Stewmath avatar Sep 17 '14 19:09 Stewmath

@Drienn unfortunately I can not get it to compile see issue #125, And I can easily notice it, I'm using ATH-M50 headphones So I can hear every bit of it when it happens, LoZ oracle of seasons it is happening constantly, I have a real Gameboy color, and this does not happen, it only happens when you change the system volume, doesn't happen in gambatte at all, at least in the music. EDIT: IT does happen a bit on gambatte, but compared to volume with that's going on, it is much more quiet then gameyob, a good solution would to just have a cubic spline interpolation process or something that would get rid of the nasty ones. Like I said LoZ oracle of seasons, is much worse then the others.I do know the clicking exists, but it is much louder then it should be or the volume in game is being turned off whenever this clicking happens.

purpasmart96 avatar Sep 18 '14 00:09 purpasmart96

Then this is probably a different issue. The clicking I'm referring to should only manifest itself when the music changes.

I can hear a bit of crackling in Seasons, but I never really noticed despite playing that and ages a lot... well, I'll look into it.

Stewmath avatar Sep 18 '14 01:09 Stewmath

All I can really says is that it sounds very UNnatural compared to gambatte. It does change during the music but it's like a little late and sounds very harsh then what it should be, the one on gambatte doesnt seem as loud and sounds perfect.

purpasmart96 avatar Sep 18 '14 02:09 purpasmart96

Also when I commented these out SCHANNEL_CR(1) = SCHANNEL_ENABLE | SOUND_VOL(0) | SOUND_PAN(64) | (0 << 29) | SOUND_REPEAT; there was still clicking, so it's something else Honestly just put a cheap filter that gets rid of the static,

purpasmart96 avatar Sep 18 '14 03:09 purpasmart96

Sorry it doesn't work that way. I'm using the sound hardware in such a way that I can't make a high-level filter for all sound. But I will see what I can do.

Stewmath avatar Sep 19 '14 17:09 Stewmath

@Drienn aww that sucks, anyways I have kinda gotten used to now, I guess it isn't as bad as my ears perceived it before, I do notice that clicking mostly comes from the left side, it is much more faint on the right side.

purpasmart96 avatar Sep 19 '14 22:09 purpasmart96

i get some strange p-p-p-p-p-p in Zelda Oracle of Ages while hearing Nayru and in the rest of the game too

IAMSolaara avatar Jan 22 '17 14:01 IAMSolaara